Claude review: drm/gem: Remove unneeded ret check in change handle ioctl

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Base mismatch — patch is obsolete.**

The patch removes these lines (from its base revision `abc8e41d6652`):

```c
	spin_unlock(&file_priv->table_lock);

-	if (ret < 0)
-		goto out_unlock;
-
	if (obj->dma_buf) {
```

The commit message states this `if (ret < 0)` check after `idr_replace` is dead code because "in the only place we modify the return value between there and the previous return value check, we also immediately jump to out_unlock, bypassing the check entirely." For an `idr_replace`-based implementation, this analysis is likely correct — `idr_replace` returns `void *` (not `int`), so any error from it would be caught via `IS_ERR()` and would immediately `goto out_unlock`, meaning `ret` is never set to a negative value in a path that falls through to this check.

**However, the current drm-next code at `drivers/gpu/drm/drm_gem.c:1044-1050` has been rewritten:**

```c
	spin_lock(&file_priv->table_lock);
	ret = idr_alloc(&file_priv->object_idr, obj, handle, handle + 1,
			GFP_NOWAIT);
	spin_unlock(&file_priv->table_lock);

	if (ret < 0)
		goto out_unlock;
```

In the current code, `ret` is set directly by `idr_alloc()`, which returns a negative errno on failure (e.g., `-ENOSPC` if the handle is already in use, `-ENOMEM`). The `if (ret < 0)` check is **not dead code** — it is essential for error handling. Removing it in the current code would cause the function to proceed with a failed allocation, leading to incorrect behavior.

**Issues:**
1. The patch does not apply — the pre-image hash `abc8e41d6652` does not match the current drm-next tree.
2. The commit message references `idr_replace`, but drm-next uses `idr_alloc` — the function has been refactored since the patch was written.
3. Naively adapting this patch to the current code would introduce a bug by removing a necessary error check on `idr_alloc`'s return value.

**Verdict:** The underlying dead-code observation was probably valid for the `idr_replace` version, but the code has moved on. This patch should be dropped. If the author rebases onto drm-next, they will find the `idr_replace` call is gone and the analogous `ret` check is no longer dead.

---
Generated by Claude Code Patch Reviewer