From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/gem: Remove unneeded ret check in change handle ioctl
Date: Sat, 16 May 2026 15:11:29 +1000 [thread overview]
Message-ID: <review-overall-20260511142540.2989187-1-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20260511142540.2989187-1-jonathan.cavitt@intel.com>
Overall Series Review
Subject: drm/gem: Remove unneeded ret check in change handle ioctl
Author: Jonathan Cavitt <jonathan.cavitt@intel.com>
Patches: 3
Reviewed: 2026-05-16T15:11:29.210502
---
This is a single-patch series that attempts to remove what it claims is a dead `if (ret < 0)` check after `idr_replace` in `drm_gem_change_handle_ioctl`. However, **the patch is based on an older version of the code that has since been refactored**. The current drm-next tree no longer uses `idr_replace` in this function — it was reworked to use `idr_alloc` + `idr_remove`. The patch does not apply cleanly, and the issue it addresses no longer exists in the current code.
**Recommendation: NAK / Obsolete** — the code the patch targets has already been restructured, making this change moot.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-16 5:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 14:25 [PATCH] drm/gem: Remove unneeded ret check in change handle ioctl Jonathan Cavitt
2026-05-14 15:16 ` Rodrigo Vivi
2026-05-14 15:23 ` Rodrigo Vivi
2026-05-16 5:11 ` Claude review: " Claude Code Review Bot
2026-05-16 5:11 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260511142540.2989187-1-jonathan.cavitt@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox