public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: sdm670-google: add common device tree include
Date: Sat, 16 May 2026 11:37:15 +1000	[thread overview]
Message-ID: <review-patch1-20260513172549.1345-2-mailingradian@gmail.com> (raw)
In-Reply-To: <20260513172549.1345-2-mailingradian@gmail.com>

Patch Review

**Overall:** Good refactoring. The split between common and device-specific properties is logical and complete.

**Positive changes:**

- The switch from inline `reg` with a computed size to `memory-region = <&fb_mem>` in the framebuffer node is a good improvement. It avoids duplicating the address and references the already-defined reserved memory region, which is the preferred DT pattern:
```
-		framebuffer@9c000000 {
+		framebuffer: framebuffer@9c000000 {
 			compatible = "simple-framebuffer";
-			reg = <0 0x9c000000 0 (1080 * 2220 * 4)>;
+			memory-region = <&fb_mem>;
 			width = <1080>;
-			height = <2220>;
+			/* height is in specific device trees */
```

- Adding labels (`framebuffer:`, `fb_mem:`, `rmi4_f12:`, `panel:`) to nodes that need per-device overrides is the correct mechanism.

- The SPDX license change from `GPL-2.0` to `GPL-2.0-only` in the rewritten sargo.dts is appropriate — `GPL-2.0` is deprecated as ambiguous. The commit message explains the rationale well.

**Minor observations (non-blocking):**

1. The comment `/* compatible is provided in specific device trees */` and `/* height is in specific device trees */` are helpful for readability, since a panel node without a compatible or a framebuffer without height would otherwise look like a bug. These are good comments.

2. The `width = <1080>` and `stride = <(1080 * 4)>` are hardcoded in the common dtsi. Both current variants (sargo and bonito-tianma) share 1080px width, so this is fine. If a future variant has a different width, it would need to override these too, but that's a bridge to cross later.

3. The rewritten `sdm670-google-sargo.dts` is pleasantly minimal — just the include and five short override blocks. This validates that the common/specific split was done well.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  1:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 17:25 [PATCH v4 0/2] arm64: dts: qcom: pixel 3a xl support with tianma panel Richard Acayan
2026-05-13 17:25 ` [PATCH v4 1/2] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-05-13 17:57   ` Dmitry Baryshkov
2026-05-16  1:37   ` Claude Code Review Bot [this message]
2026-05-13 17:25 ` [PATCH v4 2/2] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-05-13 17:58   ` Dmitry Baryshkov
2026-05-16  1:37   ` Claude review: " Claude Code Review Bot
2026-05-16  1:37 ` Claude review: arm64: dts: qcom: pixel 3a xl support with " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-10  0:26 [PATCH v3 0/5] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-03-10  0:26 ` [PATCH v3 4/5] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-03-10  1:42   ` Claude review: " Claude Code Review Bot
2026-02-17  0:08 [PATCH v2 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-17  0:08 ` [PATCH v2 5/6] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-02-17  5:51   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 [PATCH 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-10  2:32 ` [PATCH 5/6] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260513172549.1345-2-mailingradian@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox