public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: add support for pixel 3a xl with the tianma panel
Date: Sat, 16 May 2026 11:37:16 +1000	[thread overview]
Message-ID: <review-patch2-20260513172549.1345-3-mailingradian@gmail.com> (raw)
In-Reply-To: <20260513172549.1345-3-mailingradian@gmail.com>

Patch Review

**Overall:** Clean, minimal device tree for the new variant. Nothing to object to.

**Makefile ordering** is correct — `bonito` sorts before `sargo` alphabetically:
```
+dtb-$(CONFIG_ARCH_QCOM)	+= sdm670-google-bonito-tianma.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm670-google-sargo.dtb
```

**Compatible string** follows the standard most-specific-to-least-specific pattern:
```
+	compatible = "google,bonito-tianma", "google,bonito", "qcom,sdm670";
```

**Device-specific values** all check out against known hardware specs:
- Battery: `3700000` µAh (3700mAh, correct for Pixel 3a XL)
- Height: `2160` (matches the NT37700F panel binding description: "1080x2160 AMOLED")
- Panel compatible: `novatek,nt37700f` (binding and driver exist in-tree)
- Touchscreen: `69x137` mm (reasonable for 6.0" screen vs sargo's `62x127` mm for 5.6")

**Framebuffer region sizing:** The shared `fb_mem` reserved region is `0x2400000` (37.7 MB), which comfortably fits both sargo's 1080×2220×4 = 9.6 MB and bonito's 1080×2160×4 = 9.3 MB. No issue.

**No issues found in this patch.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  1:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 17:25 [PATCH v4 0/2] arm64: dts: qcom: pixel 3a xl support with tianma panel Richard Acayan
2026-05-13 17:25 ` [PATCH v4 1/2] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-05-13 17:57   ` Dmitry Baryshkov
2026-05-16  1:37   ` Claude review: " Claude Code Review Bot
2026-05-13 17:25 ` [PATCH v4 2/2] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-05-13 17:58   ` Dmitry Baryshkov
2026-05-16  1:37   ` Claude Code Review Bot [this message]
2026-05-16  1:37 ` Claude review: arm64: dts: qcom: pixel 3a xl support with " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-10  0:26 [PATCH v3 0/5] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-03-10  0:26 ` [PATCH v3 5/5] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-03-10  1:42   ` Claude review: " Claude Code Review Bot
2026-02-17  0:08 [PATCH v2 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-17  0:08 ` [PATCH v2 6/6] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-02-17  5:51   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 [PATCH 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-10  2:33 ` [PATCH 6/6] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260513172549.1345-3-mailingradian@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox