public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/nouveau/fifo/nv04: filter benign CACHE_ERROR from Mesa NV50 bind probe
Date: Sat, 16 May 2026 11:34:49 +1000	[thread overview]
Message-ID: <review-patch1-20260513175014.96599-2-marek@czernohous.de> (raw)
In-Reply-To: <20260513175014.96599-2-marek@czernohous.de>

Patch Review

**Assessment: Good — minor nits only.**

The filter is narrowly scoped and well-explained. It checks for the exact Mesa NV50 bind probe signature (method 0x0060, data 0xbeef02xx) and demotes only that case to debug level.

**Positive:** By placing the filter *before* the `else` branch that patch 2 hooks into, benign probes correctly don't count toward the Tier-2 wedge window. This is the right ordering.

**Nit 1 — debug message omits channel name.** The error path prints `chan->name` but the debug path does not:

```c
nvkm_debug(subdev, "CACHE_ERROR - ch %d subc %d mthd %04x data %08x (benign, skipped)\n",
           chid, (mthd >> 13) & 7, mthd & 0x1ffc, data);
```

This is fine for a debug-level message, but for consistency with the error message format (`ch %d [%s]`), consider including the channel name. Very minor.

**Nit 2 — comment length.** The 5-line comment block is somewhat verbose for a simple filter. The kernel style generally prefers shorter inline comments. Not a blocker.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  1:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 17:50 [PATCH 0/2] drm/nouveau: nv04 FIFO cleanup + recovery for Tesla Marek Czernohous
2026-05-13 17:50 ` [PATCH 1/2] drm/nouveau/fifo/nv04: filter benign CACHE_ERROR from Mesa NV50 bind probe Marek Czernohous
2026-05-16  1:34   ` Claude Code Review Bot [this message]
2026-05-13 17:50 ` [PATCH 2/2] drm/nouveau/fifo: add recovery path for Tesla cache_error/dma_pusher Marek Czernohous
2026-05-16  1:34   ` Claude review: " Claude Code Review Bot
2026-05-16  1:34 ` Claude review: drm/nouveau: nv04 FIFO cleanup + recovery for Tesla Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260513175014.96599-2-marek@czernohous.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox