From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: misc: fastrpc: Fix initial memory allocation for Audio PD memory pool
Date: Sat, 16 May 2026 09:09:54 +1000 [thread overview]
Message-ID: <review-patch1-20260515124217.20723-2-jianping.li@oss.qualcomm.com> (raw)
In-Reply-To: <20260515124217.20723-2-jianping.li@oss.qualcomm.com>
Patch Review
**Verdict: Looks good.**
The fix is correct. In the original code, `inbuf.pageslen` is unconditionally set to 0 *after* the remote heap allocation and SCM assignment block, so the DSP never receives the allocated buffer:
```c
// original: pageslen always 0
inbuf.client_id = fl->client_id;
inbuf.namelen = init.namelen;
inbuf.pageslen = 0;
```
The patch moves these assignments before the allocation block and sets `pageslen = 1` when the SCM assignment succeeds:
```c
+ scm_done = true;
+ inbuf.pageslen = 1;
```
This ensures the initially allocated buffer is actually registered with the Audio PD. The logic is clean: default `pageslen=0`, set to 1 only when memory is both allocated and SCM-assigned.
Note: This code is removed by patch 4, so this fix is primarily for stable backports.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-15 23:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 12:42 [PATCH v5 0/5] misc: fastrpc: Add missing bug fixes Jianping Li
2026-05-15 12:42 ` [PATCH v5 1/5] misc: fastrpc: Fix initial memory allocation for Audio PD memory pool Jianping Li
2026-05-15 13:33 ` Dmitry Baryshkov
2026-05-15 23:09 ` Claude Code Review Bot [this message]
2026-05-15 12:42 ` [PATCH v5 2/5] misc: fastrpc: Remove buffer from list prior to unmap operation Jianping Li
2026-05-15 13:36 ` Dmitry Baryshkov
2026-05-15 23:09 ` Claude review: " Claude Code Review Bot
2026-05-15 12:42 ` [PATCH v5 3/5] misc: fastrpc: Fail Audio PD init when reserved memory is missing Jianping Li
2026-05-15 13:37 ` Dmitry Baryshkov
2026-05-15 23:09 ` Claude review: " Claude Code Review Bot
2026-05-15 12:42 ` [PATCH v5 4/5] misc: fastrpc: Allocate entire reserved memory for Audio PD in probe Jianping Li
2026-05-15 13:38 ` Dmitry Baryshkov
2026-05-15 23:09 ` Claude review: " Claude Code Review Bot
2026-05-15 12:42 ` [PATCH v5 5/5] misc: fastrpc: Allow fastrpc_buf_free() to accept NULL Jianping Li
2026-05-15 23:09 ` Claude review: " Claude Code Review Bot
2026-05-15 23:09 ` Claude review: misc: fastrpc: Add missing bug fixes Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-09 6:26 [PATCH v4 0/4] " Jianping Li
2026-04-09 6:26 ` [PATCH v4 1/4] misc: fastrpc: Fix initial memory allocation for Audio PD memory pool Jianping Li
2026-04-12 1:44 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260515124217.20723-2-jianping.li@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox