public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: leds: Document TI LM3533 LED controller
Date: Mon, 18 May 2026 16:19:46 +1000	[thread overview]
Message-ID: <review-patch1-20260517074306.30937-2-clamor95@gmail.com> (raw)
In-Reply-To: <20260517074306.30937-2-clamor95@gmail.com>

Patch Review

The bindings are mostly well-structured, but have some issues:

**Overly restrictive required list**: The top-level binding requires ALL child nodes:
```yaml
required:
  - compatible
  - reg
  - light-sensor
  - backlight@0
  - backlight@1
  - led@2
  - led@3
  - led@4
  - led@5
```
Not every board will use all six control banks plus ALS. Most real boards will only use a subset. This should use `patternProperties` matching without making every child `required`, or at minimum reduce the required set to just `compatible` and `reg`.

**`led-sources` maximum off-by-one in leds binding**: The `ti,lm3533-leds.yaml` defines `items: maximum: 5`, but the LVLED indices are 0-4, so the maximum should be `4`:
```yaml
  led-sources:
    items:
      maximum: 5    # should be 4
```

**Minor**: The `ti,resistor-ohm` property description says "resister" instead of "resistor."

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-18  6:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17  7:43 [PATCH v1 0/6] mfd: lm3533: convert to OF bindings, improve support Svyatoslav Ryhel
2026-05-17  7:43 ` [PATCH v1 1/6] dt-bindings: leds: Document TI LM3533 LED controller Svyatoslav Ryhel
2026-05-17 13:44   ` Jonathan Cameron
2026-05-17 14:26     ` Svyatoslav Ryhel
2026-05-18  6:19   ` Claude Code Review Bot [this message]
2026-05-17  7:43 ` [PATCH v1 2/6] mfd: lm3533: Convert to use OF bindings Svyatoslav Ryhel
2026-05-17  7:55   ` Andy Shevchenko
2026-05-17 10:11     ` Svyatoslav Ryhel
2026-05-17 11:10   ` Svyatoslav Ryhel
2026-05-18  6:19   ` Claude review: " Claude Code Review Bot
2026-05-17  7:43 ` [PATCH v1 3/6] mfd: lm3533: Add support for VIN power supply Svyatoslav Ryhel
2026-05-18  6:19   ` Claude review: " Claude Code Review Bot
2026-05-17  7:43 ` [PATCH v1 4/6] mfd: lm3533: set DMA mask Svyatoslav Ryhel
2026-05-18  6:19   ` Claude review: " Claude Code Review Bot
2026-05-17  7:43 ` [PATCH v1 5/6] video: backlight: lm3533_bl: Set initial mapping mode from DT Svyatoslav Ryhel
2026-05-18  6:19   ` Claude review: " Claude Code Review Bot
2026-05-17  7:43 ` [PATCH v1 6/6] video: leds: backlight: lm3533: Support getting LED sources " Svyatoslav Ryhel
2026-05-18  6:19   ` Claude review: " Claude Code Review Bot
2026-05-17  7:59 ` [PATCH v1 0/6] mfd: lm3533: convert to OF bindings, improve support Andy Shevchenko
2026-05-17 10:13   ` Svyatoslav Ryhel
2026-05-17 10:20     ` Andy Shevchenko
2026-05-17 10:34       ` Svyatoslav Ryhel
2026-05-17 10:40         ` Andy Shevchenko
2026-05-17 10:44           ` Svyatoslav Ryhel
2026-05-18  6:19 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260517074306.30937-2-clamor95@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox