From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: gr2d/gr3d: Initialize address register map before HOST1X client is registered
Date: Mon, 18 May 2026 16:14:38 +1000 [thread overview]
Message-ID: <review-patch1-20260517091450.46728-2-clamor95@gmail.com> (raw)
In-Reply-To: <20260517091450.46728-2-clamor95@gmail.com>
Patch Review
**Assessment: Good, no issues.**
This patch moves the `set_bit` loop that populates `addr_regs` from after `host1x_client_register()` to before it, in both gr2d.c and gr3d.c. The rationale is sound: `host1x_client_register()` can make the device available to userspace, and `gr2d_is_addr_reg()`/`gr3d_is_addr_reg()` consult `addr_regs` during job submission validation. An uninitialized bitmap would fail to flag address registers, potentially allowing userspace to bypass address relocation checks.
The initialization depends only on the static `gr2d_addr_regs[]`/`gr3d_addr_regs[]` arrays and the already-allocated `gr2d->addr_regs`/`gr3d->addr_regs` bitmaps, so moving it earlier has no dependency issues.
The diff for both files is symmetric and minimal. No concerns.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-18 6:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 9:14 [PATCH v3 0/2] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe Svyatoslav Ryhel
2026-05-17 9:14 ` [PATCH v3 1/2] drm/tegra: gr2d/gr3d: Initialize address register map before HOST1X client is registered Svyatoslav Ryhel
2026-05-18 6:14 ` Claude Code Review Bot [this message]
2026-05-17 9:14 ` [PATCH v3 2/2] drm/tegra: gr2d/gr3d: Contain PM in the gr*d_probe/gr*d_remove Svyatoslav Ryhel
2026-05-18 6:14 ` Claude review: " Claude Code Review Bot
2026-05-18 6:14 ` Claude review: drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-03 16:38 [PATCH v2 0/2] " Svyatoslav Ryhel
2026-05-03 16:38 ` [PATCH v2 1/2] drm/tegra: gr2d/gr3d: Initialize address register map before HOST1X client is registered Svyatoslav Ryhel
2026-05-04 22:41 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260517091450.46728-2-clamor95@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox