public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: uapi: Add macro for chipset specific event ID region
Date: Mon, 25 May 2026 22:50:39 +1000	[thread overview]
Message-ID: <review-patch1-20260519140548.28853-2-bence.csokas@arm.com> (raw)
In-Reply-To: <20260519140548.28853-2-bence.csokas@arm.com>

Patch Review

**Commit message:** Clear and well-written. It explains the motivation (elevating the comment-level contract to code) and references the v1 link. Good.

**`include/uapi/drm/drm.h` changes:**

```c
+#define DRM_EVENT_VENDOR_SPECIFIC(_v) ((_v) | 0x80000000)
```

Placed correctly right after `DRM_EVENT_CRTC_SEQUENCE` (the last generic event define) and before `struct drm_event_vblank`. The kerneldoc comment is appropriate for a UAPI header. The parenthesization of `_v` in `(_v)` and the outer parens are correct macro hygiene.

One nit: the name `DRM_EVENT_VENDOR_SPECIFIC` reads like a single event rather than a constructor/range macro. Names like `DRM_EVENT_CHIPSET` or `DRM_EVENT_DRIVER` might match the existing comment wording ("chipset specific") more closely, but this is subjective and the current name is perfectly clear in context.

**`include/uapi/drm/exynos_drm.h` changes:**

```c
-#define DRM_EXYNOS_G2D_EVENT		0x80000000
-#define DRM_EXYNOS_IPP_EVENT		0x80000002
+#define DRM_EXYNOS_G2D_EVENT		DRM_EVENT_VENDOR_SPECIFIC(0x0)
+#define DRM_EXYNOS_IPP_EVENT		DRM_EVENT_VENDOR_SPECIFIC(0x2)
```

Values preserved. `drm.h` is included at line 19 of this file. Correct.

**`include/uapi/drm/virtgpu_drm.h` changes:**

```c
-#define VIRTGPU_EVENT_FENCE_SIGNALED 0x90000000
+#define VIRTGPU_EVENT_FENCE_SIGNALED DRM_EVENT_VENDOR_SPECIFIC(0x10000000)
```

`0x10000000 | 0x80000000` = `0x90000000`. Value preserved. `drm.h` is included at line 27 of this file. Correct.

**`include/uapi/drm/vmwgfx_drm.h` changes:**

```c
-#define DRM_VMW_EVENT_FENCE_SIGNALED 0x80000000
+#define DRM_VMW_EVENT_FENCE_SIGNALED DRM_EVENT_VENDOR_SPECIFIC(0x0)
```

Value preserved. `drm.h` is included at line 32 of this file. Correct.

**No issues found.** This is a clean, correct, ABI-preserving patch.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 14:05 [PATCH resend] drm: uapi: Add macro for chipset specific event ID region Bence Csokas
2026-05-25 12:50 ` Claude Code Review Bot [this message]
2026-05-25 12:50 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-08 16:36 [PATCH] " Bence Csokas
2026-04-12  2:13 ` Claude review: " Claude Code Review Bot
2026-04-12  2:13 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260519140548.28853-2-bence.csokas@arm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox