public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: fix kernel-doc warnings
Date: Mon, 25 May 2026 21:16:18 +1000	[thread overview]
Message-ID: <review-patch1-20260520183721.279669-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260520183721.279669-1-rdunlap@infradead.org>

Patch Review

**Status: Clean / Reviewed-by worthy**

**Change 1 — Add `@power_module` doc (line 333 in the patched file):**

```c
 * @freesync_module: Module handling freesync calculations
 * @power_module: Manages replay, PSR, and backlight control functionality
 * @hdcp_workqueue: AMDGPU content protection queue
```

Verified: The struct member `struct mod_power *power_module;` exists at line 579 of the patched file, and the new doc comment is placed in the correct position matching the declaration order (after `freesync_module`, before `hdcp_workqueue`). The description is accurate — `mod_power` handles PSR, replay, and backlight. Correct.

**Change 2 — Rename `@dm_boot_time_crc_info` to `@boot_time_crc_info` (line 712 in the patched file):**

```c
	/**
	 * @boot_time_crc_info:
	 *
	 * Buffer info for the boot time crc.
	 */
	struct dm_boot_time_crc_info boot_time_crc_info;
```

Verified: The struct member is `boot_time_crc_info` (line 716), not `dm_boot_time_crc_info`. The old doc tag `@dm_boot_time_crc_info` was a copy-paste error from the type name `struct dm_boot_time_crc_info`. The fix correctly makes the kernel-doc tag match the member name. Correct.

**No issues. No nits.** The commit message clearly explains the problem (with the actual warning text), the `Fixes:` tags are appropriate, and the Cc list covers the relevant maintainers.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 11:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 18:37 [PATCH] drm/amd/display: fix kernel-doc warnings Randy Dunlap
2026-05-25 11:16 ` Claude Code Review Bot [this message]
2026-05-25 11:16 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260520183721.279669-1-rdunlap@infradead.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox