public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: misc: fastrpc: Move fdlist to invoke context structure
Date: Mon, 25 May 2026 20:54:21 +1000	[thread overview]
Message-ID: <review-patch1-20260521054539.128651-2-ekansh.gupta@oss.qualcomm.com> (raw)
In-Reply-To: <20260521054539.128651-2-ekansh.gupta@oss.qualcomm.com>

Patch Review

**Status: Looks good.**

This moves the `fdlist` pointer from being locally computed in both `fastrpc_get_args()` and `fastrpc_put_args()` into the `struct fastrpc_invoke_ctx`. This eliminates redundant computation and is also necessary for patch 4 to calculate `poll_addr` relative to the end of the metadata buffer.

One subtle correctness point: the old code in `fastrpc_put_args()` computed `fdlist` as:
```c
fdlist = (uint64_t *)(pages + inbufs + outbufs + handles);
```
while the new code in `fastrpc_get_args()` computes it as:
```c
ctx->fdlist = (u64 *)(pages + ctx->nscalars);
```

These are equivalent because `nscalars = inbufs + outbufs + handles` (see `REMOTE_SCALARS_LENGTH`), so this is correct and also simpler.

Has R-b from Dmitry Baryshkov. No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 10:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  5:45 [PATCH v12 0/4] misc: fastrpc: Add polling mode support Ekansh Gupta
2026-05-21  5:45 ` [PATCH v12 1/4] misc: fastrpc: Move fdlist to invoke context structure Ekansh Gupta
2026-05-25 10:54   ` Claude Code Review Bot [this message]
2026-05-21  5:45 ` [PATCH v12 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Ekansh Gupta
2026-05-25 10:54   ` Claude review: " Claude Code Review Bot
2026-05-21  5:45 ` [PATCH v12 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Ekansh Gupta
2026-05-25 10:54   ` Claude review: " Claude Code Review Bot
2026-05-21  5:45 ` [PATCH v12 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Ekansh Gupta
2026-05-25 10:54   ` Claude review: " Claude Code Review Bot
2026-05-25 10:54 ` Claude review: misc: fastrpc: Add polling mode support Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-20  6:50 [PATCH v11 0/4] " Ekansh Gupta
2026-05-20  6:50 ` [PATCH v11 1/4] misc: fastrpc: Move fdlist to invoke context structure Ekansh Gupta
2026-05-25 12:12   ` Claude review: " Claude Code Review Bot
2026-04-22  9:24 [PATCH v9 0/4] misc: fastrpc: Add polling mode support Ekansh Gupta
2026-04-22  9:24 ` [PATCH v9 1/4] misc: fastrpc: Move fdlist to invoke context structure Ekansh Gupta
2026-04-22 21:50   ` Claude review: " Claude Code Review Bot
2026-02-15 18:21 [PATCH v6 0/4] misc: fastrpc: Add polling mode support Ekansh Gupta
2026-02-15 18:21 ` [PATCH v6 1/4] misc: fastrpc: Move fdlist to invoke context structure Ekansh Gupta
2026-02-15 22:26   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260521054539.128651-2-ekansh.gupta@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox