Claude review: drm/bridge: chipone-icn6211: use devm_mipi_dsi_attach

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Change summary:** Converts `mipi_dsi_attach(dsi)` to `devm_mipi_dsi_attach(dev, dsi)` in `chipone_dsi_attach()`, then removes the now-empty `chipone_dsi_remove()` callback and its registration in the driver struct.

**Correctness:**

The `dev` parameter passed to `devm_mipi_dsi_attach`:

```c
static int chipone_dsi_attach(struct chipone *icn)
{
	struct mipi_dsi_device *dsi = icn->dsi;
	struct device *dev = icn->dev;
	...
	ret = devm_mipi_dsi_attach(dev, dsi);
```

This function is called from two probe paths:

1. **DSI probe** (`chipone_dsi_probe`): `icn->dev` = `&dsi->dev`, so the detach action is tied to the DSI device. Correct — matches the old `chipone_dsi_remove` behavior.

2. **I2C probe** (`chipone_i2c_probe` → `chipone_dsi_host_attach` → `chipone_dsi_attach`): `icn->dev` = `&client->dev` (the I2C device). The detach action is tied to the I2C device lifecycle. This is actually an **improvement** over the current tree — the I2C driver has no `.remove` callback, so `mipi_dsi_detach` was never called on I2C device removal. With this patch, managed cleanup handles it correctly.

**Removal of `chipone_dsi_remove`:** The patch is based on a tree where the prior `devm_drm_bridge_add()` conversion already removed `drm_bridge_remove()` from this callback, leaving only `mipi_dsi_detach(dsi)`. Since that's now handled by `devm_mipi_dsi_attach`, the entire callback becomes empty and can be safely removed. The current drm-next tree still has `drm_bridge_remove()` in `chipone_dsi_remove()` at line 771, which is why the patch doesn't apply cleanly — it depends on the prior conversion landing first.

**No issues found.** The patch is straightforward and correct.

Reviewed-by: Dave Airlie <airlied@gmail.com>

---
Generated by Claude Code Patch Reviewer