public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ci: disable mr-label-maker-test
Date: Mon, 25 May 2026 19:21:31 +1000	[thread overview]
Message-ID: <review-patch1-20260522-drm-ci-mr-label-v1-1-39f778123b30@oss.qualcomm.com> (raw)
In-Reply-To: <20260522-drm-ci-mr-label-v1-1-39f778123b30@oss.qualcomm.com>

Patch Review

**Correctness:** The patch adds a job override block that matches the established pattern in the file:

```yaml
mr-label-maker-test:
   rules:
    - when: never
```

This is identical in structure to the surrounding disabled jobs (`deploy-docs` at line 381, `linkcheck-docs` at line 385, `test-docs` at line 393). The placement is alphabetically/logically correct — inserted between `linkcheck-docs` and `test-docs`.

**Indentation:** Uses the same 3-space indent for `rules:` and 4-space indent for `- when: never`, consistent with the rest of the file.

**No concerns:**
- The commit message adequately explains both the problem (job got enabled, blocks pipeline) and the rationale (MR labelling is not used for DRM CI).
- The `Link:` tag to the failing pipeline is helpful for reviewers to verify the issue.
- The `Signed-off-by` is present.
- The `base-commit` is specified, making it easy to apply.

**Reviewed-by worthy.** This is a clean, minimal fix following existing conventions.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-25  9:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22  2:28 [PATCH] drm/ci: disable mr-label-maker-test Dmitry Baryshkov
2026-05-25  9:21 ` Claude review: " Claude Code Review Bot
2026-05-25  9:21 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260522-drm-ci-mr-label-v1-1-39f778123b30@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox