* [PATCH] drm/ci: disable mr-label-maker-test
@ 2026-05-22 2:28 Dmitry Baryshkov
2026-05-25 9:21 ` Claude review: " Claude Code Review Bot
2026-05-25 9:21 ` Claude Code Review Bot
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-05-22 2:28 UTC (permalink / raw)
To: Helen Koike, Vignesh Raman, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Clark,
Sean Paul, Konrad Dybcio, Akhil P Oommen
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
The MR labelling is not used for DRM CI, however the job got enabled as
a part of the CI pipeline and now prevents it from being executed.
Disable the mr-label-maker-test job implicitly.
Link: https://gitlab.freedesktop.org/drm/msm/-/pipelines/1672049
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/gpu/drm/ci/gitlab-ci.yml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml
index 56088c5393cd..c1087731d1a2 100644
--- a/drivers/gpu/drm/ci/gitlab-ci.yml
+++ b/drivers/gpu/drm/ci/gitlab-ci.yml
@@ -386,6 +386,10 @@ linkcheck-docs:
rules:
- when: never
+mr-label-maker-test:
+ rules:
+ - when: never
+
test-docs:
rules:
- when: never
---
base-commit: 687da68900cd1a46549f7d9430c7d40346cb86a0
change-id: 20260522-drm-ci-mr-label-727766d73e95
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Claude review: drm/ci: disable mr-label-maker-test
2026-05-22 2:28 [PATCH] drm/ci: disable mr-label-maker-test Dmitry Baryshkov
@ 2026-05-25 9:21 ` Claude Code Review Bot
2026-05-25 9:21 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-05-25 9:21 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: drm/ci: disable mr-label-maker-test
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-05-25T19:21:30.943658
---
This is a single, straightforward patch that disables the `mr-label-maker-test` CI job in the DRM CI pipeline. The commit message explains the problem clearly: the MR labelling job is not used by DRM CI but got pulled in as part of the CI pipeline and is now blocking execution. The linked pipeline (1672049) provides traceable context.
The fix is minimal and follows the exact same pattern used for other unused jobs in the same file (`deploy-docs`, `linkcheck-docs`, `test-docs`, etc.) — override the job with `rules: - when: never` to unconditionally disable it.
**Verdict: Looks good.** No issues found.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Claude review: drm/ci: disable mr-label-maker-test
2026-05-22 2:28 [PATCH] drm/ci: disable mr-label-maker-test Dmitry Baryshkov
2026-05-25 9:21 ` Claude review: " Claude Code Review Bot
@ 2026-05-25 9:21 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-05-25 9:21 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Correctness:** The patch adds a job override block that matches the established pattern in the file:
```yaml
mr-label-maker-test:
rules:
- when: never
```
This is identical in structure to the surrounding disabled jobs (`deploy-docs` at line 381, `linkcheck-docs` at line 385, `test-docs` at line 393). The placement is alphabetically/logically correct — inserted between `linkcheck-docs` and `test-docs`.
**Indentation:** Uses the same 3-space indent for `rules:` and 4-space indent for `- when: never`, consistent with the rest of the file.
**No concerns:**
- The commit message adequately explains both the problem (job got enabled, blocks pipeline) and the rationale (MR labelling is not used for DRM CI).
- The `Link:` tag to the failing pipeline is helpful for reviewers to verify the issue.
- The `Signed-off-by` is present.
- The `base-commit` is specified, making it easy to apply.
**Reviewed-by worthy.** This is a clean, minimal fix following existing conventions.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-25 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-22 2:28 [PATCH] drm/ci: disable mr-label-maker-test Dmitry Baryshkov
2026-05-25 9:21 ` Claude review: " Claude Code Review Bot
2026-05-25 9:21 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox