Claude review: drm/tegra: sor: Remove usage of drm_simple_encoder_init()

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Correctness: Good.** The transformation is faithful to the original helper implementation:

Original in `drm_simple_kms_helper.c`:
```c
static const struct drm_encoder_funcs drm_simple_encoder_funcs_cleanup = {
    .destroy = drm_encoder_cleanup,
};
int drm_simple_encoder_init(...) {
    return drm_encoder_init(dev, encoder,
                            &drm_simple_encoder_funcs_cleanup,
                            encoder_type, NULL);
}
```

New code in `sor.c`:
```c
static const struct drm_encoder_funcs tegra_sor_encoder_funcs_cleanup = {
    .destroy = drm_encoder_cleanup,
};
...
drm_encoder_init(drm, &sor->output.encoder, &tegra_sor_encoder_funcs_cleanup, encoder, NULL);
```

This is a correct 1:1 translation.

**Nit 1 — Naming convention.** The struct is named `tegra_sor_encoder_funcs_cleanup`, which appends `_cleanup` to emphasize that the only op is `.destroy = drm_encoder_cleanup`. This mirrors the internal naming in `drm_simple_kms_helper.c`, but the more conventional name in DRM drivers would be simply `tegra_sor_encoder_funcs`. The `_cleanup` suffix is slightly unusual for a `drm_encoder_funcs` struct name and could be confusing (it reads like a cleanup function rather than a funcs table). That said, this is subjective and minor.

**Nit 2 — Line length.** The replacement call:
```c
drm_encoder_init(drm, &sor->output.encoder, &tegra_sor_encoder_funcs_cleanup, encoder, NULL);
```
is 88 characters, which exceeds the preferred 80-column limit. The existing tegra code is not strict about 80 columns but does generally wrap long function calls. Consider wrapping it for consistency with the surrounding style, e.g.:
```c
drm_encoder_init(drm, &sor->output.encoder,
                 &tegra_sor_encoder_funcs_cleanup,
                 encoder, NULL);
```

**Note — unchecked return value.** Both `drm_simple_encoder_init()` (before) and `drm_encoder_init()` (after) return `int`, and neither is checked. This is a pre-existing issue in the tegra driver (same pattern in `hdmi.c`, `rgb.c`, `dsi.c`) and not something this patch needs to fix, but worth noting. The todo.rst task is specifically about removing the `drm_simple_encoder_init` wrapper, not fixing error handling.

**Overall: Patch is correct and suitable for merging, optionally with the naming and line-length adjustments.**

---
Generated by Claude Code Patch Reviewer