Claude review: drm/tegra: sor: Remove usage of drm_simple_encoder_init()

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/tegra: sor: Remove usage of drm_simple_encoder_init()
Author: Jacob McLemore <jmclemore.lkml@gmail.com>
Patches: 1
Reviewed: 2026-05-25T18:06:52.645017

---

This is a single-patch series that removes one usage of the deprecated `drm_simple_encoder_init()` helper from the tegra SOR driver, as described in `Documentation/gpu/todo.rst`. The patch correctly inlines the helper by defining a local `drm_encoder_funcs` struct with `.destroy = drm_encoder_cleanup` and replacing the `drm_simple_encoder_init()` call with a direct `drm_encoder_init()` call. This is a straightforward mechanical conversion and the author has followed the todo.rst instructions correctly.

The patch is functionally correct — the inlined code is a faithful reproduction of what `drm_simple_encoder_init()` does internally (confirmed by reading `drm_simple_kms_helper.c:23-30`). The `#include <drm/drm_simple_kms_helper.h>` removal is also correct since no other symbols from that header are used in `sor.c`.

**Verdict: The patch looks good. Two minor style nits below, neither blocking.**

---
Generated by Claude Code Patch Reviewer