[PATCH] dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible

[PATCH] dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible

[Yijie Yang]

Document compatible string for the FastRPC interface on the Qualcomm Maili
SoC, which is compatible with the Qualcomm Kaanapali FastRPC and can
fallback to Kaanapali.

Assisted-by: Claude:claude-opus-4-6
Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
index 2876fdd7c6e6..afe52296bf1d 100644
--- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
+++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
@@ -26,6 +26,7 @@ properties:
           - enum:
               - qcom,glymur-fastrpc
               - qcom,hawi-fastrpc
+              - qcom,maili-fastrpc
           - const: qcom,kaanapali-fastrpc
 
   label:

---
base-commit: 550604d6c9b9efc8d068aff94dc301694a7afdee
change-id: 20260512-fastrpc-9f3b691f8e2d

Best regards,
--  
Yijie Yang <yijie.yang@oss.qualcomm.com>

Claude review: dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible

[Claude Code Review Bot]

Overall Series Review

Subject: dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible
Author: Yijie Yang <yijie.yang@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-05-25T16:43:13.149933

---

This is a single-patch series adding one new compatible string (`qcom,maili-fastrpc`) to the `qcom,fastrpc` device tree binding. The patch is trivial — a one-line addition to a YAML enumeration.

**Assessment: The patch is correct and follows the established pattern.** It adds the Maili SoC's FastRPC compatible string to the existing enum that falls back to `qcom,kaanapali-fastrpc`, matching the same pattern used by `qcom,glymur-fastrpc` and `qcom,hawi-fastrpc`.

There is one minor observation worth noting:

- **`Assisted-by: Claude:claude-opus-4-6`**: This is a non-standard tag. The kernel community has discussed AI-assisted contributions. The commonly accepted tag for AI assistance is `Co-developed-by:` or specific project-agreed forms. This tag format may draw review comments from maintainers.

No technical issues found. The alphabetical ordering of the enum entries is correct (glymur, hawi, maili).

---
Generated by Claude Code Patch Reviewer

Claude review: dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible

[Claude Code Review Bot]

Patch Review

**Correctness**: The change is correct. It adds `qcom,maili-fastrpc` to the inner `enum` under the `items` list, paired with the `const: qcom,kaanapali-fastrpc` fallback. This means a DT can declare:
```
compatible = "qcom,maili-fastrpc", "qcom,kaanapali-fastrpc";
```
which is the expected two-entry compatible pattern for SoC-specific strings with a fallback.

**Ordering**: The new entry is in alphabetical order within the enum (glymur < hawi < maili), which is good.

**Commit message**: The commit message is clear and describes the relationship (Maili is compatible with Kaanapali and falls back to it). Minor nit: "Kaanapali" is capitalized inconsistently between the subject line and body, though this is cosmetic.

**Tag concern**: The `Assisted-by: Claude:claude-opus-4-6` tag is non-standard for the kernel. Maintainers may ask for it to be dropped or reformatted. This isn't a blocking issue for the DT binding itself, but worth flagging.

No code-level issues. This is a clean, minimal patch.

---
Generated by Claude Code Patch Reviewer