public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: misc: fastrpc: fix channel ctx ref leak when session alloc fails
Date: Tue, 26 May 2026 07:21:42 +1000	[thread overview]
Message-ID: <review-patch1-20260525085340.2734738-1-anandu.e@oss.qualcomm.com> (raw)
In-Reply-To: <20260525085340.2734738-1-anandu.e@oss.qualcomm.com>

Patch Review

**Correctness: Good.** The flow is clear:

1. `fastrpc_channel_ctx_get(cctx)` at line 1634 increments the refcount.
2. On success, `fastrpc_device_release()` eventually calls `fastrpc_channel_ctx_put(cctx)` at line 1610.
3. On failure of `fastrpc_session_alloc()`, the early return at line 1652 skips the release path entirely, leaking the reference. The added `fastrpc_channel_ctx_put(cctx)` before the return fixes this.

**One minor style nit:** The patch removes a blank line that existed between `kfree(fl)` and `return -EBUSY`:

```c
-
+		fastrpc_channel_ctx_put(cctx);
 		return -EBUSY;
```

This is fine — the blank line was arguably unnecessary, and inserting the put call there is the logical place (after freeing `fl`, before returning). The ordering is correct: `mutex_destroy` then `kfree` then `put` — the `cctx` doesn't depend on `fl` being alive, so the put can safely go after the free.

**No issues found.** The commit message accurately describes the problem, the Fixes tag references the correct commit that introduced the refcounting, and the stable CC is warranted since this is a resource leak that could prevent channel context cleanup.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-25 21:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25  8:53 [PATCH v1] misc: fastrpc: fix channel ctx ref leak when session alloc fails Anandu Krishnan E
2026-05-25  9:16 ` Dmitry Baryshkov
2026-05-25 21:21 ` Claude review: " Claude Code Review Bot
2026-05-25 21:21 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260525085340.2734738-1-anandu.e@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox