From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: misc: fastrpc: fix channel ctx ref leak when session alloc fails
Date: Tue, 26 May 2026 07:21:41 +1000 [thread overview]
Message-ID: <review-overall-20260525085340.2734738-1-anandu.e@oss.qualcomm.com> (raw)
In-Reply-To: <20260525085340.2734738-1-anandu.e@oss.qualcomm.com>
Overall Series Review
Subject: misc: fastrpc: fix channel ctx ref leak when session alloc fails
Author: Anandu Krishnan E <anandu.e@oss.qualcomm.com>
Patches: 2
Reviewed: 2026-05-26T07:21:41.793346
---
This is a single-patch fix for a genuine reference count leak in the fastrpc driver. The analysis is correct: `fastrpc_channel_ctx_get()` is called at line 1634 of `fastrpc_device_open()`, but if `fastrpc_session_alloc()` fails at line 1646, the error path at lines 1648-1652 returns without calling `fastrpc_channel_ctx_put()`. The normal release path in `fastrpc_device_release()` (line 1610) does call the put, but that path is never reached when session alloc fails because the file was never fully opened.
The fix is correct and minimal. The Fixes tag and stable CC are appropriate.
**Verdict: Patch looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 8:53 [PATCH v1] misc: fastrpc: fix channel ctx ref leak when session alloc fails Anandu Krishnan E
2026-05-25 9:16 ` Dmitry Baryshkov
2026-05-25 21:21 ` Claude Code Review Bot [this message]
2026-05-25 21:21 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260525085340.2734738-1-anandu.e@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox