public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: PCI/TPH: expose the enabled TPH requester type
Date: Wed, 27 May 2026 14:35:49 +1000	[thread overview]
Message-ID: <review-patch1-20260526144401.1485788-2-zhipingz@meta.com> (raw)
In-Reply-To: <20260526144401.1485788-2-zhipingz@meta.com>

Patch Review

A small, clean accessor to avoid drivers reaching into `pci_dev` internals.

**Observation: EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL**

```c
u8 pcie_tph_enabled_req_type(struct pci_dev *pdev)
{
	return pdev->tph_req_type;
}
EXPORT_SYMBOL(pcie_tph_enabled_req_type);
```

The existing `pcie_tph_get_st_table_loc` also uses plain `EXPORT_SYMBOL`, so this is consistent with the file's convention. However, many newer PCI subsystem exports use `EXPORT_SYMBOL_GPL`. The PCI maintainers may have a preference here — worth confirming, but not a blocker since the file is internally consistent.

**Stub return value:** The `!CONFIG_PCIE_TPH` stub returns `0`, which maps to `PCI_TPH_REQ_DISABLE`. This is correct — callers will see TPH as disabled, which is the safe default.

No other issues. Clean patch.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-27  4:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 14:43 [PATCH v5 0/4] vfio/dma-buf: add TPH support for peer-to-peer access Zhiping Zhang
2026-05-26 14:43 ` [PATCH v5 1/4] PCI/TPH: expose the enabled TPH requester type Zhiping Zhang
2026-05-27  4:35   ` Claude Code Review Bot [this message]
2026-05-26 14:43 ` [PATCH v5 2/4] dma-buf: add optional get_tph() callback Zhiping Zhang
2026-05-27  4:35   ` Claude review: " Claude Code Review Bot
2026-05-26 14:43 ` [PATCH v5 3/4] vfio/pci: implement get_tph and DMA_BUF_TPH feature Zhiping Zhang
2026-05-27  4:35   ` Claude review: " Claude Code Review Bot
2026-05-26 14:43 ` [PATCH v5 4/4] RDMA/mlx5: get tph for p2p access when registering dma-buf mr Zhiping Zhang
2026-05-27  4:35   ` Claude review: " Claude Code Review Bot
2026-05-27  4:35 ` Claude review: vfio/dma-buf: add TPH support for peer-to-peer access Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-19 20:13 [PATCH v4 0/3] " Zhiping Zhang
2026-05-19 20:13 ` [PATCH v4 2/3] PCI/TPH: expose the enabled TPH requester type Zhiping Zhang
2026-05-25 12:27   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260526144401.1485788-2-zhipingz@meta.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox