From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/pagefault: Add SRCID to pagefault struct
Date: Wed, 27 May 2026 14:00:17 +1000 [thread overview]
Message-ID: <review-patch1-20260526214446.3638616-2-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20260526214446.3638616-2-jonathan.cavitt@intel.com>
Patch Review
**Verdict: Looks good.**
The `PFD_SRC_ID` field is `GENMASK(10, 3)` — an 8-bit value that fits cleanly in the new `u8 srcid` field.
The `reserved` field change from `u64 reserved` to `u8 reserved[7]` correctly maintains the 8-byte footprint at the same offset (16), keeping the struct at its documented 64-byte size:
```c
/** @consumer.srcid: ID of hardware unit producing fault */
u8 srcid;
/** @consumer.reserved: reserved bits for future expansion */
u8 reserved[7];
```
The print format addition is correct — `0x%02x` for a `u8` value, and the argument ordering matches the format string.
No issues with this patch.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-27 4:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 21:44 [PATCH 0/2] drm/xe/pagefault: Add SRCID to pagefault reporting Jonathan Cavitt
2026-05-26 21:44 ` [PATCH 1/2] drm/xe/pagefault: Add SRCID to pagefault struct Jonathan Cavitt
2026-05-27 4:00 ` Claude Code Review Bot [this message]
2026-05-26 21:44 ` [PATCH 2/2] drm/xe/vm: Add srcid to xe_vm_get_property_ioctl fault report Jonathan Cavitt
2026-05-27 4:00 ` Claude review: " Claude Code Review Bot
2026-05-27 4:00 ` Claude review: drm/xe/pagefault: Add SRCID to pagefault reporting Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260526214446.3638616-2-jonathan.cavitt@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox