From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/pagefault: Add SRCID to pagefault reporting
Date: Wed, 27 May 2026 14:00:17 +1000 [thread overview]
Message-ID: <review-overall-20260526214446.3638616-1-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20260526214446.3638616-1-jonathan.cavitt@intel.com>
Overall Series Review
Subject: drm/xe/pagefault: Add SRCID to pagefault reporting
Author: Jonathan Cavitt <jonathan.cavitt@intel.com>
Patches: 3
Reviewed: 2026-05-27T14:00:17.515622
---
This is a small 2-patch series adding the SRCID (source ID of the faulting hardware unit) to the xe pagefault reporting path. The data flows from the GuC pagefault handler through the internal pagefault struct, gets saved into per-VM fault entries, and is exposed to userspace via the `xe_vm_get_property_ioctl`.
The series is mostly clean, but **Patch 2 has a bug**: it accidentally removes the MBZ validation of the `pad` field in `drm_xe_vm_get_property`, which is completely unrelated to the srcid feature. Additionally, the UAPI for `srcid` lacks the `#define` documentation that the sibling fields have, making it harder for userspace to interpret the value.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-27 4:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 21:44 [PATCH 0/2] drm/xe/pagefault: Add SRCID to pagefault reporting Jonathan Cavitt
2026-05-26 21:44 ` [PATCH 1/2] drm/xe/pagefault: Add SRCID to pagefault struct Jonathan Cavitt
2026-05-27 4:00 ` Claude review: " Claude Code Review Bot
2026-05-26 21:44 ` [PATCH 2/2] drm/xe/vm: Add srcid to xe_vm_get_property_ioctl fault report Jonathan Cavitt
2026-05-27 4:00 ` Claude review: " Claude Code Review Bot
2026-05-27 4:00 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260526214446.3638616-1-jonathan.cavitt@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox