public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: bridge: ti-sn65dsi83: Remove NO_HFP and NO_HBP mode flags for LVDS stability
Date: Thu, 28 May 2026 12:36:19 +1000	[thread overview]
Message-ID: <review-patch1-20260527085736.920390-2-tessolveupstream@gmail.com> (raw)
In-Reply-To: <20260527085736.920390-2-tessolveupstream@gmail.com>

Patch Review

**Verdict: Good patch, should be accepted.**

The change removes `MIPI_DSI_MODE_VIDEO_NO_HFP` and `MIPI_DSI_MODE_VIDEO_NO_HBP` from the DSI mode flags:

```c
 dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
-                  MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP |
                   MIPI_DSI_MODE_VIDEO_NO_HSA | MIPI_DSI_MODE_NO_EOT_PACKET;
```

This is well-justified. The `NO_HFP`/`NO_HBP` flags tell the DSI host it can skip sending horizontal front/back porch periods, but the driver programs these exact values into the bridge chip's registers at lines 672–677:

```c
regmap_write(ctx->regmap, REG_VID_CHA_HORIZONTAL_BACK_PORCH,
             (mode->htotal - mode->hsync_end) / dual_factor);
regmap_write(ctx->regmap, REG_VID_CHA_HORIZONTAL_FRONT_PORCH,
             (mode->hsync_start - mode->hdisplay) / dual_factor);
```

The bridge chip clearly needs these blanking periods to reconstruct valid LVDS timings. Suppressing them on the DSI link while expecting the bridge to use them is inconsistent. The datasheet reference strengthens the argument. Note that `MIPI_DSI_MODE_VIDEO_NO_HSA` is intentionally retained — this is reasonable since the bridge has its own hsync-width register (`REG_VID_CHA_HSYNC_PULSE_WIDTH`) and can reconstruct HSA from the programmed value.

No issues with the code change itself. Two independent Tested-by tags add confidence.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-28  2:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27  8:57 [PATCH v4 0/2] drm: bridge: ti-sn65dsi83: Fix DSI mode flags for stable LVDS output Sudarshan Shetty
2026-05-27  8:57 ` [PATCH v4 1/2] drm: bridge: ti-sn65dsi83: Remove NO_HFP and NO_HBP mode flags for LVDS stability Sudarshan Shetty
2026-05-28  2:36   ` Claude Code Review Bot [this message]
2026-05-27  8:57 ` [PATCH v4 2/2] drm: bridge: ti-sn65dsi83: Disable video burst mode " Sudarshan Shetty
2026-05-28  2:36   ` Claude review: " Claude Code Review Bot
2026-05-28  2:36 ` Claude review: drm: bridge: ti-sn65dsi83: Fix DSI mode flags for stable LVDS output Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260527085736.920390-2-tessolveupstream@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox