public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: bridge: ti-sn65dsi83: Disable video burst mode for LVDS stability
Date: Thu, 28 May 2026 12:36:19 +1000	[thread overview]
Message-ID: <review-patch2-20260527085736.920390-3-tessolveupstream@gmail.com> (raw)
In-Reply-To: <20260527085736.920390-3-tessolveupstream@gmail.com>

Patch Review

**Verdict: Acceptable but with a reservation about regression risk.**

The change removes `MIPI_DSI_MODE_VIDEO_BURST`:

```c
-	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
-			  MIPI_DSI_MODE_VIDEO_NO_HSA | MIPI_DSI_MODE_NO_EOT_PACKET;
+	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_NO_HSA |
+			  MIPI_DSI_MODE_NO_EOT_PACKET;
```

Without `MIPI_DSI_MODE_VIDEO_BURST`, the DSI link will operate in non-burst sync-event mode. The justification — that burst mode depends on continuous clocking behavior from the DSI host and may be unreliable — is plausible but somewhat generic.

**Points to consider:**

1. **Regression risk:** Unlike patch 1 (where the logic was clearly contradictory), burst mode is a valid DSI mode and this driver has shipped with it since its introduction. Removing it could cause issues on platforms where burst mode is currently working and non-burst mode is not — different DSI host controllers may behave differently. The Tested-by tags are from only two platforms.

2. **The commit message is honest** about the nature of the problem ("depending on the host controller implementation"), which is good. However, it would benefit from naming the specific DSI host controller or SoC where the instability was observed to help future readers understand the scope.

3. **No `Fixes:` tag** is present on either patch. If this is considered a bug fix (which the title "for LVDS stability" implies), a Fixes tag pointing to the original commit that added burst mode would be appropriate for backport tracking.

4. **`MIPI_DSI_MODE_VIDEO_NO_HSA` and `MIPI_DSI_MODE_NO_EOT_PACKET` are retained.** This is fine — `NO_HSA` is a reasonable optimization when the bridge programs hsync width via register, and `NO_EOT_PACKET` is commonly used with TI bridges.

The code change itself is trivially correct — it's just flag removal and reformatting the line continuation. No functional issues with the implementation.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-28  2:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27  8:57 [PATCH v4 0/2] drm: bridge: ti-sn65dsi83: Fix DSI mode flags for stable LVDS output Sudarshan Shetty
2026-05-27  8:57 ` [PATCH v4 1/2] drm: bridge: ti-sn65dsi83: Remove NO_HFP and NO_HBP mode flags for LVDS stability Sudarshan Shetty
2026-05-28  2:36   ` Claude review: " Claude Code Review Bot
2026-05-27  8:57 ` [PATCH v4 2/2] drm: bridge: ti-sn65dsi83: Disable video burst mode " Sudarshan Shetty
2026-05-28  2:36   ` Claude Code Review Bot [this message]
2026-05-28  2:36 ` Claude review: drm: bridge: ti-sn65dsi83: Fix DSI mode flags for stable LVDS output Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260527085736.920390-3-tessolveupstream@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox