public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: Wrap user-invoked calls to fb_set_var() in helper
Date: Thu, 28 May 2026 12:12:50 +1000	[thread overview]
Message-ID: <review-patch1-20260527151551.258659-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20260527151551.258659-2-tzimmermann@suse.de>

Patch Review

**Bug: sh_mobile_lcdcfb loses "update all VCs" behavior**

The original `sh_mobile_fb_reconfig()` code was:

```c
if (fb_set_var(info, &var) < 0)
    return;

fbcon_update_vcs(info, true);  /* <-- always updates ALL VCs */
```

After this patch, it calls `fb_set_var_from_user(info, &var)`, which internally does:

```c
fbcon_update_vcs(info, var->activate & FB_ACTIVATE_ALL);
```

Since `var.activate = FB_ACTIVATE_NOW` (value 0) in `sh_mobile_fb_reconfig`, the expression `0 & 64` evaluates to `0` (false). This changes the behavior from updating **all** VCs to only the **current** VC.

When a display is re-plugged with a different mode, all consoles mapped to that framebuffer should be updated - the original `true` was intentional. The fix should be:

```c
var.activate = FB_ACTIVATE_NOW | FB_ACTIVATE_ALL;
```

in `sh_mobile_fb_reconfig()` before calling `fb_set_var_from_user`.

**ps3fb now gains fbcon_modechange_possible check** - This is a new pre-condition that wasn't present before. The cover letter says this is intentional ("fix inconsistencies"), which is reasonable, but worth noting as a behavioral change: if fbcon rejects the mode, ps3fb's ioctl will now return an error where it previously would have succeeded.

**Export level**: `EXPORT_SYMBOL(fb_set_var_from_user)` is consistent with `EXPORT_SYMBOL(fb_set_var)`. Correct, since ps3fb and sh_mobile_lcdcfb can be built as modules.

**Declaration placement**: `fb_set_var_from_user` is declared in `include/linux/fb.h` (public header), which is correct since it's called from drivers outside fbdev core.

The rest of the patch is mechanical and correct.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-28  2:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 15:14 [PATCH v3 0/4] fbdev: Internalize fbcon Thomas Zimmermann
2026-05-27 15:14 ` [PATCH v3 1/4] fbdev: Wrap user-invoked calls to fb_set_var() in helper Thomas Zimmermann
2026-05-28  2:12   ` Claude Code Review Bot [this message]
2026-05-27 15:14 ` [PATCH v3 2/4] fbdev: Wrap user-invoked calls to fb_blank() " Thomas Zimmermann
2026-05-28  2:12   ` Claude review: " Claude Code Review Bot
2026-05-27 15:14 ` [PATCH v3 3/4] fbdev: Wrap fbcon updates from vga-switcheroo " Thomas Zimmermann
2026-05-28  2:12   ` Claude review: " Claude Code Review Bot
2026-05-27 15:14 ` [PATCH v3 4/4] fbdev: Do not export fbcon from fbdev Thomas Zimmermann
2026-05-28  2:12   ` Claude review: " Claude Code Review Bot
2026-05-28  2:12 ` Claude review: fbdev: Internalize fbcon Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-22 12:28 [PATCH v2 0/4] " Thomas Zimmermann
2026-05-22 12:28 ` [PATCH v2 1/4] fbdev: Wrap user-invoked calls to fb_set_var() in helper Thomas Zimmermann
2026-05-25  8:52   ` Claude review: " Claude Code Review Bot
2026-05-20 16:00 [PATCH 0/4] fbdev: Internalize fbcon Thomas Zimmermann
2026-05-20 16:00 ` [PATCH 1/4] fbdev: Wrap user-invoked calls to fb_set_var() in helper Thomas Zimmermann
2026-05-25 11:30   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260527151551.258659-2-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox