From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: Wrap fbcon updates from vga-switcheroo in helper
Date: Thu, 28 May 2026 12:12:51 +1000 [thread overview]
Message-ID: <review-patch3-20260527151551.258659-4-tzimmermann@suse.de> (raw)
In-Reply-To: <20260527151551.258659-4-tzimmermann@suse.de>
Patch Review
Clean. `fb_switch_outputs()` is a thin wrapper around `fbcon_remap_all()`, correctly placed in `fbmem.c` and exported for vga-switcheroo's use.
**Kconfig change**: The dependency changes from `(FRAMEBUFFER_CONSOLE=n || FB=y)` to `FB=y`. This is slightly more restrictive — previously vga-switcheroo could be built if FRAMEBUFFER_CONSOLE was disabled even without FB=y, but that seems like a pathological configuration. With the new `fb_switch_outputs` living in fbmem.c (part of FB), requiring `FB=y` is correct.
The `#if defined(CONFIG_FB)` guard in `vga_switcheroo.c` is technically redundant with the Kconfig `depends on FB=y`, but it's harmless belt-and-suspenders and was flagged in v3 review feedback from Geert.
Removal of `#include <linux/console.h>` and `#include <linux/fbcon.h>` from vga_switcheroo.c is correct — those interfaces are no longer used directly.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-28 2:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 15:14 [PATCH v3 0/4] fbdev: Internalize fbcon Thomas Zimmermann
2026-05-27 15:14 ` [PATCH v3 1/4] fbdev: Wrap user-invoked calls to fb_set_var() in helper Thomas Zimmermann
2026-05-28 2:12 ` Claude review: " Claude Code Review Bot
2026-05-27 15:14 ` [PATCH v3 2/4] fbdev: Wrap user-invoked calls to fb_blank() " Thomas Zimmermann
2026-05-28 2:12 ` Claude review: " Claude Code Review Bot
2026-05-27 15:14 ` [PATCH v3 3/4] fbdev: Wrap fbcon updates from vga-switcheroo " Thomas Zimmermann
2026-05-28 2:12 ` Claude Code Review Bot [this message]
2026-05-27 15:14 ` [PATCH v3 4/4] fbdev: Do not export fbcon from fbdev Thomas Zimmermann
2026-05-28 2:12 ` Claude review: " Claude Code Review Bot
2026-05-28 2:12 ` Claude review: fbdev: Internalize fbcon Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-22 12:28 [PATCH v2 0/4] " Thomas Zimmermann
2026-05-22 12:28 ` [PATCH v2 3/4] fbdev: Wrap fbcon updates from vga-switcheroo in helper Thomas Zimmermann
2026-05-25 8:52 ` Claude review: " Claude Code Review Bot
2026-05-20 16:00 [PATCH 0/4] fbdev: Internalize fbcon Thomas Zimmermann
2026-05-20 16:00 ` [PATCH 3/4] fbdev: Wrap fbcon updates from vga-switcheroo in helper Thomas Zimmermann
2026-05-25 11:30 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260527151551.258659-4-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox