public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: ttm/pool: Don't leak LRU list on shutdown
Date: Thu, 28 May 2026 12:07:00 +1000	[thread overview]
Message-ID: <review-patch1-20260527202018.1223912-1-ian.forbes@broadcom.com> (raw)
In-Reply-To: <20260527202018.1223912-1-ian.forbes@broadcom.com>

Patch Review

**Correctness: Good.** The added `list_lru_destroy(&pt->pages)` is placed after the LRU walk and dispose, which is the right ordering — all entries are drained first, then the LRU infrastructure is freed. This mirrors the standard `list_lru_init` / `list_lru_destroy` lifecycle used throughout the kernel.

**Placement within `ttm_pool_type_fini`:**

```c
list_lru_walk(&pt->pages, pool_move_to_dispose_list, &dispose, LONG_MAX);
ttm_pool_dispose_list(pt, &dispose);
list_lru_destroy(&pt->pages);
```

The destroy comes after draining, which is correct. Calling `list_lru_destroy` on a non-empty LRU would be a bug, but the walk + dispose above guarantee it's empty.

**Commit message:** Clear and concise. The `Fixes:` tag correctly references the commit that introduced the `list_lru` conversion. The description of how it was found (kmemleak + igt hotunplug) is helpful for reviewers.

**No issues found.** This is a clean, correct one-line fix.

Reviewed-by assessment: **Accept.** No changes needed.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-28  2:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 20:20 [PATCH] ttm/pool: Don't leak LRU list on shutdown Ian Forbes
2026-05-28  2:06 ` Claude review: " Claude Code Review Bot
2026-05-28  2:07 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260527202018.1223912-1-ian.forbes@broadcom.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox