public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imx/dcss: add missing kernel-doc parameters for scaler functions
Date: Thu, 04 Jun 2026 15:09:58 +1000	[thread overview]
Message-ID: <review-patch1-20260530195925.5477-1-rosenp@gmail.com> (raw)
In-Reply-To: <20260530195925.5477-1-rosenp@gmail.com>

Patch Review

**Correctness: Good.** Both additions match the actual function signatures.

For `dcss_scaler_gaussian_filter()` (line 171–173 of `dcss-scaler.c`):
```c
static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
					bool phase0_identity,
					int coef[][PSC_NUM_TAPS])
```
The parameter `phase0_identity` was indeed undocumented and sits between `use_5_taps` and `coef`. The patch correctly inserts `@phase0_identity` in the right position:
```
+ * @phase0_identity: use identity filter for phase 0
```

For `dcss_scaler_filter_design()` (lines 267–270):
```c
static void dcss_scaler_filter_design(int src_length, int dst_length,
				      bool use_5_taps, bool phase0_identity,
				      int coef[][PSC_NUM_TAPS],
				      bool nn_interpolation)
```
Both `phase0_identity` and `nn_interpolation` were missing. The patch adds them in the correct order matching the function signature:
```
+ * @phase0_identity: use identity filter for phase 0
  * @coef: output coefficients
+ * @nn_interpolation: use nearest neighbor interpolation
```

**Minor nit:** The `Assisted-by:` tag in the commit message (`Assisted-by: Opencode:Big-pickle`) is not a standard kernel tag. The kernel community does not have a formally accepted `Assisted-by:` trailer. If this is intended to credit AI assistance, there's currently no agreed-upon convention for this in the kernel. Maintainers may want the author to drop this tag or use a different approach per subsystem policy.

**Verdict:** Trivially correct doc fix. No functional code changes. Looks good to apply, modulo the non-standard tag question.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-06-04  5:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 19:59 [PATCH] drm/imx/dcss: add missing kernel-doc parameters for scaler functions Rosen Penev
2026-06-02  7:18 ` Laurentiu Palcu
2026-06-04  5:09 ` Claude review: " Claude Code Review Bot
2026-06-04  5:09 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260530195925.5477-1-rosenp@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox