public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dpu: fix parameter name in dpu_core_perf_adjusted_mode_clk kernel-doc
Date: Thu, 04 Jun 2026 15:08:55 +1000	[thread overview]
Message-ID: <review-patch1-20260530201342.10538-1-rosenp@gmail.com> (raw)
In-Reply-To: <20260530201342.10538-1-rosenp@gmail.com>

Patch Review

**Status**: Correct.

The change at `drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:37`:

```
- * @crtc_clk_rate - Unadjusted mode clock rate
+ * @mode_clk_rate: unadjusted mode clock rate
```

Verified against the function signature at line 40:

```c
u64 dpu_core_perf_adjusted_mode_clk(u64 mode_clk_rate,
```

The parameter is indeed `mode_clk_rate`, not `crtc_clk_rate`. The separator fix from `-` to `:` also aligns with kernel-doc format requirements (kernel-doc uses `@param:` not `@param -`). The capitalization change ("Unadjusted" to "unadjusted") is also consistent with the existing `@perf_cfg` description on the next line which uses lowercase.

**Minor note**: The `Assisted-by: Opencode:Big-pickle` tag is non-standard. The kernel community typically uses `Co-developed-by:` for human collaborators, or specific AI-assistance tags that have been discussed on LKML. This is cosmetic and up to the maintainer whether to accept or request a change to the tag.

No issues with the code change itself.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  5:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 20:13 [PATCH] drm/msm/dpu: fix parameter name in dpu_core_perf_adjusted_mode_clk kernel-doc Rosen Penev
2026-06-04  5:08 ` Claude Code Review Bot [this message]
2026-06-04  5:08 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260530201342.10538-1-rosenp@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox