public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT
Date: Thu, 04 Jun 2026 13:25:57 +1000	[thread overview]
Message-ID: <review-patch1-20260602004515.1907422-1-runyu.xiao@seu.edu.cn> (raw)
In-Reply-To: <20260602004515.1907422-1-runyu.xiao@seu.edu.cn>

Patch Review

**Change:**
```c
-	ret = generic_handle_irq(display->audio.lpe.irq);
+	ret = generic_handle_irq_safe(display->audio.lpe.irq);
```

**Analysis:**

- **Correctness:** The fix is correct. `generic_handle_irq()` requires hard IRQ context (per its documentation: "must be called from an IRQ context with irq regs initialized"). On PREEMPT_RT, the i915 interrupt handler is force-threaded, so it runs in process context. `generic_handle_irq_safe()` explicitly handles this by doing `local_irq_save()`/`local_irq_restore()` around the actual handler dispatch (confirmed at `kernel/irq/irqdesc.c:710-712`), making it callable from any context.

- **No functional regression on non-RT:** On non-RT kernels where the handler already runs in hard IRQ context, interrupts are already disabled, so the `local_irq_save()`/`local_irq_restore()` in `generic_handle_irq_safe()` is a no-op — no performance or behavioral difference.

- **Scope:** The change is appropriately minimal. Only this one call site in `intel_lpe_audio_irq_handler()` needs the fix — the caller is the i915 IRQ handler chain, and this is the point where IRQs get forwarded to the LPE audio chained IRQ chip.

- **Commit message:** Accurate and clear. Correctly identifies the PREEMPT_RT threading issue and the Braswell audio platform affected.

**No issues found.** 

Reviewed-by worthy as-is.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  3:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02  0:45 [PATCH v3] drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT Runyu Xiao
2026-06-02  6:29 ` Sebastian Andrzej Siewior
2026-06-02 12:33   ` Maarten Lankhorst
2026-06-03  8:27     ` Jani Nikula
2026-06-03 13:28       ` Runyu Xiao
2026-06-04  3:25 ` Claude Code Review Bot [this message]
2026-06-04  3:25 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260602004515.1907422-1-runyu.xiao@seu.edu.cn \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox