public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT
Date: Thu, 04 Jun 2026 13:25:57 +1000	[thread overview]
Message-ID: <review-overall-20260602004515.1907422-1-runyu.xiao@seu.edu.cn> (raw)
In-Reply-To: <20260602004515.1907422-1-runyu.xiao@seu.edu.cn>

Overall Series Review

Subject: drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT
Author: Runyu Xiao <runyu.xiao@seu.edu.cn>
Patches: 4
Reviewed: 2026-06-04T13:25:57.081447

---

This is a single-patch fix (v3) that replaces `generic_handle_irq()` with `generic_handle_irq_safe()` in the LPE audio IRQ forwarding path. The change is correct and well-motivated: on PREEMPT_RT kernels, i915's IRQ handler runs in threaded context (not hard IRQ context), so `generic_handle_irq()` — which requires hard IRQ context — is inappropriate. `generic_handle_irq_safe()` wraps the call with `local_irq_save()`/`local_irq_restore()`, making it safe from any context.

The fix is minimal, one-line, and uses the correct upstream API. The commit message accurately describes the problem and the solution. The current drm-next tree still has `generic_handle_irq()` at line 265, confirming this fix is still needed.

**One process concern:** The Signed-off-by chain has Maarten Lankhorst as From/author with his own Signed-off-by, then Runyu Xiao's Signed-off-by as the submitter. The v3 changelog says this is a rebase of Maarten's original fix. The Reviewed-by tags from Matthew Brost and Uma Shankar are carried forward — this is acceptable if the patch content hasn't materially changed from what they reviewed, which appears to be the case (same one-line change).

**Verdict: Looks good.** This is a straightforward, correct RT fix.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  3:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02  0:45 [PATCH v3] drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT Runyu Xiao
2026-06-02  6:29 ` Sebastian Andrzej Siewior
2026-06-02 12:33   ` Maarten Lankhorst
2026-06-03  8:27     ` Jani Nikula
2026-06-03 13:28       ` Runyu Xiao
2026-06-04  3:25 ` Claude Code Review Bot [this message]
2026-06-04  3:25 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260602004515.1907422-1-runyu.xiao@seu.edu.cn \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox