public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] drm/amdgpu: fix inconsistent indenting in amdgpu_gfx_ring_preempt_ib
Date: Sat, 16 May 2026 12:23:11 +1000	[thread overview]
Message-ID: <review-patch1-606b422c-4531-4950-a22e-61732383f6b5@amd.com> (raw)
In-Reply-To: <606b422c-4531-4950-a22e-61732383f6b5@amd.com>

Patch Review

**Status: Correct, minor commit message nit**

The fix itself is obviously correct. I verified against the current drm-next tree at line 2730 of `amdgpu_gfx.c`:

```c
	/* deassert preemption condition */
    amdgpu_ring_set_preempt_cond_exec(ring, true);
```

The line uses 4 spaces for indentation, while every other line in the function uses tabs. The patch replaces the spaces with a tab:

```c
	/* deassert preemption condition */
	amdgpu_ring_set_preempt_cond_exec(ring, true);
```

This aligns it with the matching call earlier in the function (line 2711):

```c
	/* assert preemption condition */
	amdgpu_ring_set_preempt_cond_exec(ring, false);
```

**Minor nit on commit message:** The commit message says "Fixes a whitespace indentation issue reported by the smatch static checker tool" but doesn't include a `Fixes:` tag pointing to the commit that introduced the bad indentation. For a pure whitespace fix this is arguably unnecessary, but if reviewers want one, it would point to the commit that introduced the space-indented line. This is not a blocker.

**No functional concerns.** The patch is a trivial whitespace-only change with no behavioral impact.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  2:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 14:01 [PATCH] drm/amdgpu: fix inconsistent indenting in amdgpu_gfx_ring_preempt_ib Leonardo Cesar
2026-05-12 16:26 ` Christian König
2026-05-16  2:23   ` Claude Code Review Bot [this message]
2026-05-16  2:23   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-606b422c-4531-4950-a22e-61732383f6b5@amd.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox