Claude review: drm/panel: jdi-lt070me05000: Transition to mipi_dsi *_multi() functions

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Verdict: Already applied (superseded), with several issues compared to the existing conversion.**

The drm-next tree already contains this conversion (done more thoroughly). Comparing the patch against the current tree reveals several shortcomings:

1. **Context variable naming**: The patch uses `ctx` while the tree uses `dsi_ctx`. Minor style difference, but indicates the patch was developed against a stale base.

2. **Sleep calls not converted**: The patch keeps bare `usleep_range()` and `mdelay()`/`msleep()` calls:
   ```c
   usleep_range(10000, 20000);
   ...
   msleep(120);
   ...
   mdelay(10);
   ...
   mdelay(20);
   ```
   The tree converts these to `mipi_dsi_usleep_range()` and `mipi_dsi_msleep()`, which properly short-circuit when `accum_err` is set, avoiding unnecessary delays after a failure.

3. **`mipi_dsi_generic_write_multi()` vs `mipi_dsi_generic_write_seq_multi()`**: The patch uses `mipi_dsi_generic_write_multi()` with explicit casts and length parameters:
   ```c
   mipi_dsi_generic_write_multi(&ctx, (u8[]){0xB0, 0x00}, 2);
   ```
   The tree uses the cleaner `mipi_dsi_generic_write_seq_multi()` macro which infers the length automatically:
   ```c
   mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb0, 0x00);
   ```
   This is both more readable and less error-prone (no risk of length mismatch).

4. **Unused `dev` variable removal**: The patch removes `struct device *dev = &jdi->dsi->dev;` which is correct since the `dev_err()` calls are removed, but the existing tree also handles this properly.

5. **`jdi_panel_on()` and `jdi_panel_off()` not converted**: The patch only converts `jdi_panel_init()`. The existing tree also converts `jdi_panel_on()` and `jdi_panel_off()` to use the multi context pattern, making it a more complete conversion.

**Summary**: This patch is redundant — the work has already been merged in a better form. If it were being reviewed on its own merits, the feedback would be: use `mipi_dsi_*_seq_multi()` macros instead of raw `mipi_dsi_generic_write_multi()`, convert the sleep calls to `mipi_dsi_msleep()`/`mipi_dsi_usleep_range()`, and extend the conversion to `jdi_panel_on()` and `jdi_panel_off()` as well.

---
Generated by Claude Code Patch Reviewer