public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: dw_hdmi_qp: Restrict HPD event to the affected connector
Date: Tue, 28 Apr 2026 15:25:22 +1000	[thread overview]
Message-ID: <review-patch10-20260426-dw-hdmi-qp-scramb-v5-10-d778e70c317b@collabora.com> (raw)
In-Reply-To: <20260426-dw-hdmi-qp-scramb-v5-10-d778e70c317b@collabora.com>

Patch Review

Switches from `drm_helper_hpd_irq_event()` (polls all connectors) to `drm_connector_helper_hpd_irq_event()` (targets a specific connector). Adds `struct drm_connector *connector` to `rockchip_hdmi_qp` to track the relevant connector.

```c
-	if (drm) {
-		changed = drm_helper_hpd_irq_event(drm);
+	if (hdmi->connector) {
+		changed = drm_connector_helper_hpd_irq_event(hdmi->connector);
```

The `hdmi->connector` is set in `bind()` (after patch 9 ensures the connector is fully initialized) and cleared in `unbind()`. The NULL check before use in the HPD work and resume path is correct.

The `connector = NULL` in unbind runs after `cancel_delayed_work_sync(&hdmi->hpd_work)`, so no racing work item will see a stale pointer.

Has R-b from Heiko. **No issues.**

---

## SUMMARY

The series is well-organized and at v5 has addressed most review feedback. The only substantive point I'd raise:

1. **Patch 5:** The `hdmi->scramb_enabled = false` on the failure path in `dw_hdmi_qp_enable_scramb()` should use `WRITE_ONCE` for consistency with the `READ_ONCE` in the scramb_work, even though it's not a live race at that point.

2. **Patch 5:** Consider documenting the locking assumption that protects `curr_conn` from concurrent access between `detect_ctx` (which reads it) and `atomic_disable` (which clears it). The connection_mutex should serialize these, but an explicit comment would help future readers.

These are minor nits; the series looks good for merge.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-28  5:25 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26  0:20 [PATCH v5 00/10] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-04-26  0:20 ` [PATCH v5 01/10] drm/bridge: Remove redundant error check in drm_bridge_helper_reset_crtc() Cristian Ciocaltea
2026-04-27 21:46   ` Dmitry Baryshkov
2026-04-28  5:25   ` Claude review: " Claude Code Review Bot
2026-04-26  0:20 ` [PATCH v5 02/10] drm/bridge: Add detect_ctx hook and drm_bridge_detect_ctx() helper Cristian Ciocaltea
2026-04-27 11:00   ` Heiko Stuebner
2026-04-28  5:25   ` Claude review: " Claude Code Review Bot
2026-04-26  0:20 ` [PATCH v5 03/10] drm/bridge-connector: Use cached connector status in .get_modes() Cristian Ciocaltea
2026-04-27 21:52   ` Dmitry Baryshkov
2026-04-28  5:25   ` Claude review: " Claude Code Review Bot
2026-04-26  0:20 ` [PATCH v5 04/10] drm/bridge-connector: Switch to .detect_ctx() for connector detection Cristian Ciocaltea
2026-04-27 21:54   ` Dmitry Baryshkov
2026-04-28  5:25   ` Claude review: " Claude Code Review Bot
2026-04-26  0:20 ` [PATCH v5 05/10] drm/bridge: dw-hdmi-qp: Add HDMI 2.0 SCDC scrambling and high TMDS clock ratio support Cristian Ciocaltea
2026-04-27 10:49   ` Heiko Stuebner
2026-04-27 16:39     ` Cristian Ciocaltea
2026-04-27 19:09       ` Heiko Stuebner
2026-04-27 19:10   ` Heiko Stuebner
2026-04-28  1:38   ` Dmitry Baryshkov
2026-04-28  5:25   ` Claude review: " Claude Code Review Bot
2026-04-26  0:20 ` [PATCH v5 06/10] drm/bridge: dw-hdmi-qp: Rate limit i2c read error messages Cristian Ciocaltea
2026-04-27 10:41   ` Heiko Stuebner
2026-04-28  5:25   ` Claude review: " Claude Code Review Bot
2026-04-26  0:20 ` [PATCH v5 07/10] drm/rockchip: dw_hdmi_qp: Add missing newlines in dev_err_probe() messages Cristian Ciocaltea
2026-04-27 10:39   ` Heiko Stuebner
2026-04-28  1:40   ` Dmitry Baryshkov
2026-04-28  5:25   ` Claude review: " Claude Code Review Bot
2026-04-26  0:20 ` [PATCH v5 08/10] drm/rockchip: dw_hdmi_qp: Use local dev variable consistently in bind() Cristian Ciocaltea
2026-04-27 10:39   ` Heiko Stuebner
2026-04-28  5:25   ` Claude review: " Claude Code Review Bot
2026-04-26  0:20 ` [PATCH v5 09/10] drm/rockchip: dw_hdmi_qp: Register HPD IRQ after connector setup Cristian Ciocaltea
2026-04-28  1:41   ` Dmitry Baryshkov
2026-04-28  5:25   ` Claude review: " Claude Code Review Bot
2026-04-26  0:20 ` [PATCH v5 10/10] drm/rockchip: dw_hdmi_qp: Restrict HPD event to the affected connector Cristian Ciocaltea
2026-04-28  1:53   ` Dmitry Baryshkov
2026-04-28  5:25   ` Claude Code Review Bot [this message]
2026-04-28  5:25 ` Claude review: Add HDMI 2.0 support to DW HDMI QP TX Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch10-20260426-dw-hdmi-qp-scramb-v5-10-d778e70c317b@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox