From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Add HDMI 2.0 support to DW HDMI QP TX
Date: Tue, 28 Apr 2026 15:25:19 +1000 [thread overview]
Message-ID: <review-overall-20260426-dw-hdmi-qp-scramb-v5-0-d778e70c317b@collabora.com> (raw)
In-Reply-To: <20260426-dw-hdmi-qp-scramb-v5-0-d778e70c317b@collabora.com>
Overall Series Review
Subject: Add HDMI 2.0 support to DW HDMI QP TX
Author: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Patches: 26
Reviewed: 2026-04-28T15:25:19.150012
---
This is a well-structured v5 series by Cristian Ciocaltea that adds HDMI 2.0 support (4K@60Hz) to the Synopsys DW HDMI QP TX controller on Rockchip RK3576/RK3588 SoCs. The core contribution is SCDC scrambling and high TMDS clock ratio management for rates above 340 MHz.
The series is logically ordered: patches 1-4 introduce the infrastructure (atomic-aware `detect_ctx` bridge hook), patch 5 implements the SCDC feature, patches 6-8 are minor cleanups, and patches 9-10 improve HPD handling. The series has been through 5 revisions with good review feedback incorporated, including tested-by tags from two testers and R-b from Heiko on the later patches.
The overall design is sound. Key concerns are around the concurrency model for `curr_conn` and `scramb_enabled` in patch 5 (discussed below), and a minor behavioral subtlety in the `detect_ctx` fallback path.
**Overall: Good shape. A few points to discuss on patch 5's concurrency, but nothing blocking.**
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 5:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 0:20 [PATCH v5 00/10] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-04-26 0:20 ` [PATCH v5 01/10] drm/bridge: Remove redundant error check in drm_bridge_helper_reset_crtc() Cristian Ciocaltea
2026-04-27 21:46 ` Dmitry Baryshkov
2026-04-28 5:25 ` Claude review: " Claude Code Review Bot
2026-04-26 0:20 ` [PATCH v5 02/10] drm/bridge: Add detect_ctx hook and drm_bridge_detect_ctx() helper Cristian Ciocaltea
2026-04-27 11:00 ` Heiko Stuebner
2026-04-28 5:25 ` Claude review: " Claude Code Review Bot
2026-04-26 0:20 ` [PATCH v5 03/10] drm/bridge-connector: Use cached connector status in .get_modes() Cristian Ciocaltea
2026-04-27 21:52 ` Dmitry Baryshkov
2026-04-28 5:25 ` Claude review: " Claude Code Review Bot
2026-04-26 0:20 ` [PATCH v5 04/10] drm/bridge-connector: Switch to .detect_ctx() for connector detection Cristian Ciocaltea
2026-04-27 21:54 ` Dmitry Baryshkov
2026-04-28 5:25 ` Claude review: " Claude Code Review Bot
2026-04-26 0:20 ` [PATCH v5 05/10] drm/bridge: dw-hdmi-qp: Add HDMI 2.0 SCDC scrambling and high TMDS clock ratio support Cristian Ciocaltea
2026-04-27 10:49 ` Heiko Stuebner
2026-04-27 16:39 ` Cristian Ciocaltea
2026-04-27 19:09 ` Heiko Stuebner
2026-04-27 19:10 ` Heiko Stuebner
2026-04-28 1:38 ` Dmitry Baryshkov
2026-04-28 5:25 ` Claude review: " Claude Code Review Bot
2026-04-26 0:20 ` [PATCH v5 06/10] drm/bridge: dw-hdmi-qp: Rate limit i2c read error messages Cristian Ciocaltea
2026-04-27 10:41 ` Heiko Stuebner
2026-04-28 5:25 ` Claude review: " Claude Code Review Bot
2026-04-26 0:20 ` [PATCH v5 07/10] drm/rockchip: dw_hdmi_qp: Add missing newlines in dev_err_probe() messages Cristian Ciocaltea
2026-04-27 10:39 ` Heiko Stuebner
2026-04-28 1:40 ` Dmitry Baryshkov
2026-04-28 5:25 ` Claude review: " Claude Code Review Bot
2026-04-26 0:20 ` [PATCH v5 08/10] drm/rockchip: dw_hdmi_qp: Use local dev variable consistently in bind() Cristian Ciocaltea
2026-04-27 10:39 ` Heiko Stuebner
2026-04-28 5:25 ` Claude review: " Claude Code Review Bot
2026-04-26 0:20 ` [PATCH v5 09/10] drm/rockchip: dw_hdmi_qp: Register HPD IRQ after connector setup Cristian Ciocaltea
2026-04-28 1:41 ` Dmitry Baryshkov
2026-04-28 5:25 ` Claude review: " Claude Code Review Bot
2026-04-26 0:20 ` [PATCH v5 10/10] drm/rockchip: dw_hdmi_qp: Restrict HPD event to the affected connector Cristian Ciocaltea
2026-04-28 1:53 ` Dmitry Baryshkov
2026-04-28 5:25 ` Claude review: " Claude Code Review Bot
2026-04-28 5:25 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-23 17:45 [PATCH RESEND v4 0/4] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-03-24 21:36 ` Claude review: " Claude Code Review Bot
2026-03-03 1:38 [PATCH v4 0/4] " Cristian Ciocaltea
2026-03-03 2:42 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260426-dw-hdmi-qp-scramb-v5-0-d778e70c317b@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox