From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: pci: make Driver trait lifetime-parameterized
Date: Tue, 28 Apr 2026 13:47:57 +1000 [thread overview]
Message-ID: <review-patch11-20260427221155.2144848-12-dakr@kernel.org> (raw)
In-Reply-To: <20260427221155.2144848-12-dakr@kernel.org>
Patch Review
The core conversion pattern for PCI. `Adapter<T: Driver>` becomes `Adapter<F: ForLt>` with `for<'a> F::Of<'a>: Driver<'a>`. The probe callback now uses `<F::Of<'_> as Driver<'_>>::probe(pdev, info)` -- the turbofish syntax is verbose but necessary.
The `module_pci_driver!` macro change from `($($f:tt)*)` to `(type: $type:ty, $($rest:tt)*)` is a breaking change but needed to wrap the type in `ForLt!()`. This is consistent across all bus types.
In `probe_callback`, `info` is now looked up inside `from_result(|| { ... })` rather than outside. This is important -- it ensures the `info` borrow lifetime matches the callback scope.
### PATCHES 12-13: platform and auxiliary Driver trait lifetime-parameterized
Follow the same pattern as PCI patch 11. No additional concerns.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 3:47 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 22:10 [PATCH 00/24] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-04-27 22:10 ` [PATCH 01/24] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH 02/24] rust: types: add `ForLt` trait for higher-ranked lifetime support Danilo Krummrich
2026-04-27 22:16 ` Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH 03/24] rust: devres: add ForLt support to Devres Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH 04/24] rust: device: generalize drvdata methods over ForLt Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH 05/24] rust: driver: make Adapter trait lifetime-parameterized Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH 06/24] rust: pci: implement Sync for Device<Bound> Danilo Krummrich
2026-04-27 23:52 ` Gary Guo
2026-04-27 22:11 ` [PATCH 07/24] rust: platform: " Danilo Krummrich
2026-04-27 22:11 ` [PATCH 08/24] rust: auxiliary: " Danilo Krummrich
2026-04-27 22:11 ` [PATCH 09/24] rust: usb: " Danilo Krummrich
2026-04-27 22:11 ` [PATCH 10/24] rust: device: " Danilo Krummrich
2026-04-27 22:11 ` [PATCH 11/24] rust: pci: make Driver trait lifetime-parameterized Danilo Krummrich
2026-04-28 3:47 ` Claude Code Review Bot [this message]
2026-04-27 22:11 ` [PATCH 12/24] rust: platform: " Danilo Krummrich
2026-04-27 22:11 ` [PATCH 13/24] rust: auxiliary: " Danilo Krummrich
2026-04-27 22:11 ` [PATCH 14/24] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH 15/24] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH 16/24] rust: usb: make Driver trait lifetime-parameterized Danilo Krummrich
2026-04-27 22:11 ` [PATCH 17/24] rust: i2c: " Danilo Krummrich
2026-04-27 22:11 ` [PATCH 18/24] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH 19/24] rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH 20/24] samples: rust: rust_driver_pci: use HRT lifetime for Bar Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH REF 21/24] gpu: nova-core: " Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH REF 22/24] gpu: nova-core: unregister sysmem flush page from Drop Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH REF 23/24] gpu: nova-core: replace ARef<Device> with &'a Device in SysmemFlush Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-27 22:11 ` [PATCH REF 24/24] gpu: drm: tyr: use HRT lifetime for IoMem Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
2026-04-28 3:47 ` Claude review: rust: device: Higher-Ranked Lifetime Types for device drivers Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch11-20260427221155.2144848-12-dakr@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox