public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Process GPU events in IRQ context
Date: Sat, 16 May 2026 13:32:47 +1000	[thread overview]
Message-ID: <review-patch11-20260512-panthor-signal-from-irq-v2-11-95c614a739cb@collabora.com> (raw)
In-Reply-To: <20260512-panthor-signal-from-irq-v2-11-95c614a739cb@collabora.com>

Patch Review

Similar to patch 9, converts the GPU IRQ handler to a hard handler. The handler is even simpler than the JOB case:

```c
static irqreturn_t panthor_gpu_irq_raw_handler(int irq, void *data)
{
    struct panthor_irq *pirq = data;
    ...
    u32 status = gpu_read(gpu->irq.iomem, INT_STAT);
    if (!status)
        return IRQ_NONE;

    gpu_write(gpu->irq.iomem, INT_CLEAR, status);
    // ... process events ...
    return IRQ_HANDLED;
}
```

**Note:** This handler bypasses the `panthor_irq` state machine entirely — it doesn't check/set `PROCESSING`/`ACTIVE` states. It reads `INT_STAT`, clears, processes, and returns. The `panthor_irq_{suspend,resume}` functions still manage the `INT_MASK` register, so suspending will mask interrupts and no events will fire. This is acceptable because the GPU handler doesn't need the threaded handler's mask-unmask dance; it just processes events directly.

The handler body is the same as the old `panthor_gpu_irq_handler()` — it calls `gpu_write(INT_CLEAR)`, logs faults, and does `wake_up_all()` under `reqs_lock` (now with `irqsave`). All of this is IRQ-safe.

No concerns.

---

## Summary

The series is well-organized with clean incremental steps. The main risk area is patch 6 (the `events_lock` introduction and fence signalling from IRQ context), but the approach is correct. All lock conversions to `irqsave` appear correct. The `dma_fence_signal_locked()` from hard IRQ context is permissible and is exactly the pattern used by most other DRM drivers.

I have no blocking objections. The series looks ready to merge after broader testing is completed.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  3:32 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 11:37 [PATCH v2 00/11] drm/panthor: Reduce dma_fence signalling latency Boris Brezillon
2026-05-12 11:37 ` [PATCH v2 01/11] drm/panthor: Make panthor_irq::state a non-atomic field Boris Brezillon
2026-05-12 18:40   ` Chia-I Wu
2026-05-16  3:32   ` Claude review: " Claude Code Review Bot
2026-05-12 11:37 ` [PATCH v2 02/11] drm/panthor: Move the register accessors before the IRQ helpers Boris Brezillon
2026-05-12 18:41   ` Chia-I Wu
2026-05-16  3:32   ` Claude review: " Claude Code Review Bot
2026-05-12 11:37 ` [PATCH v2 03/11] drm/panthor: Replace the panthor_irq macro machinery by inline helpers Boris Brezillon
2026-05-12 18:58   ` Chia-I Wu
2026-05-13  8:03     ` Boris Brezillon
2026-05-13 16:46       ` Chia-I Wu
2026-05-16  3:32   ` Claude review: " Claude Code Review Bot
2026-05-12 11:37 ` [PATCH v2 04/11] drm/panthor: Extend the IRQ logic to allow fast/hard IRQ handlers Boris Brezillon
2026-05-12 19:11   ` Chia-I Wu
2026-05-13  8:09     ` Boris Brezillon
2026-05-13 17:06       ` Chia-I Wu
2026-05-13 17:30         ` Boris Brezillon
2026-05-13 18:17           ` Chia-I Wu
2026-05-16  3:32   ` Claude review: " Claude Code Review Bot
2026-05-12 11:37 ` [PATCH v2 05/11] drm/panthor: Make panthor_fw_{update,toggle}_reqs() callable from IRQ context Boris Brezillon
2026-05-12 19:29   ` [PATCH v2 05/11] drm/panthor: Make panthor_fw_{update, toggle}_reqs() " Chia-I Wu
2026-05-16  3:32   ` Claude review: drm/panthor: Make panthor_fw_{update,toggle}_reqs() " Claude Code Review Bot
2026-05-12 11:37 ` [PATCH v2 06/11] drm/panthor: Prepare the scheduler logic for FW events in " Boris Brezillon
2026-05-12 21:04   ` Chia-I Wu
2026-05-13  8:29     ` Boris Brezillon
2026-05-13 17:47       ` Chia-I Wu
2026-05-16  3:32   ` Claude review: " Claude Code Review Bot
2026-05-12 11:37 ` [PATCH v2 07/11] drm/panthor: Automate CSG IRQ processing at group unbind time Boris Brezillon
2026-05-12 21:16   ` Chia-I Wu
2026-05-14 14:17   ` Steven Price
2026-05-16  3:32   ` Claude review: " Claude Code Review Bot
2026-05-12 11:37 ` [PATCH v2 08/11] drm/panthor: Automatically enable interrupts in panthor_fw_wait_acks() Boris Brezillon
2026-05-12 21:55   ` Chia-I Wu
2026-05-13  8:42     ` Boris Brezillon
2026-05-13 17:14       ` Chia-I Wu
2026-05-14 14:25   ` Steven Price
2026-05-16  3:32   ` Claude review: " Claude Code Review Bot
2026-05-12 11:37 ` [PATCH v2 09/11] drm/panthor: Process FW events in IRQ context Boris Brezillon
2026-05-12 22:05   ` Chia-I Wu
2026-05-12 22:09     ` Chia-I Wu
2026-05-13  8:44       ` Boris Brezillon
2026-05-14 15:23   ` Steven Price
2026-05-16  3:32   ` Claude review: " Claude Code Review Bot
2026-05-12 11:37 ` [PATCH v2 10/11] drm/panthor: Use the irqsave variant of spin_lock in panthor_gpu_irq_handler() Boris Brezillon
2026-05-14 15:26   ` Steven Price
2026-05-16  3:32   ` Claude review: " Claude Code Review Bot
2026-05-12 11:37 ` [PATCH v2 11/11] drm/panthor: Process GPU events in IRQ context Boris Brezillon
2026-05-12 11:50   ` Boris Brezillon
2026-05-12 22:40     ` Chia-I Wu
2026-05-13  8:54       ` Boris Brezillon
2026-05-13 18:07         ` Chia-I Wu
2026-05-16  3:32   ` Claude Code Review Bot [this message]
2026-05-16  3:32 ` Claude review: drm/panthor: Reduce dma_fence signalling latency Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch11-20260512-panthor-signal-from-irq-v2-11-95c614a739cb@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox