From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: device: make Core and CoreInternal lifetime-parameterized
Date: Tue, 26 May 2026 06:47:03 +1000 [thread overview]
Message-ID: <review-patch11-20260525202921.124698-12-dakr@kernel.org> (raw)
In-Reply-To: <20260525202921.124698-12-dakr@kernel.org>
Patch Review
Changes `Core` and `CoreInternal` from unit structs to lifetime-parameterized:
```rust
-pub struct Core;
+pub struct Core<'a>(PhantomData<&'a ()>);
-pub struct CoreInternal;
+pub struct CoreInternal<'a>(PhantomData<&'a ()>);
```
Updates the `__impl_device_context_deref` and `__impl_device_context_into_aref` macros with new lifetime-parameterized variants. This is a large but mechanical change that touches all probe/unbind signatures across all buses and samples to use `Core<'_>`. The `dma::Device` trait also becomes lifetime-parameterized.
New macro variants handle the lifetime properly:
```rust
+ (unsafe { $device:ident, <$lt:lifetime> $src:ty => $dst:ty }) => {
+ impl<$lt> ::core::ops::Deref for $device<$src> {
```
Well-structured. No issues.
### PATCHES 12-16: make Driver trait lifetime-parameterized (PCI, platform, auxiliary, USB, I2C)
Each patch follows the same pattern. For PCI (patch 12) as representative:
```rust
- type Data: Send;
+ type Data<'bound>: Send + 'bound;
...
- fn probe(dev: &Device<device::Core<'_>>, id_info: &Self::IdInfo)
- -> impl PinInit<Self::Data, Error>;
+ fn probe<'bound>(
+ dev: &'bound Device<device::Core<'_>>,
+ id_info: &'bound Self::IdInfo,
+ ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound;
```
The `'bound` lifetime is introduced on the method rather than the trait, avoiding a global trait lifetime. The `+ 'bound` on the return type allows the initializer to capture references from the arguments. The `unbind` signature gains the same pattern. SAFETY comments updated to reference `T::Data<'_>`.
The I2C patch (16) also handles `shutdown` callback. USB patch (15) handles `disconnect`. All consistent. Each existing driver sets `type Data<'bound> = Self`, preserving behavior.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 20:47 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 20:20 [PATCH v5 00/24] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 01/24] rust: pci: use 'static lifetime for PCI BAR resource names Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:20 ` [PATCH v5 02/24] rust: alloc: remove `'static` bound on `ForeignOwnable` Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:20 ` [PATCH v5 03/24] rust: driver: move 'static bounds to constructor Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:20 ` [PATCH v5 04/24] rust: driver: decouple driver private data from driver type Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:20 ` [PATCH v5 05/24] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:20 ` [PATCH v5 06/24] rust: pci: implement Sync for Device<Bound> Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 07/24] rust: platform: " Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 08/24] rust: auxiliary: " Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 09/24] rust: usb: " Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 10/24] rust: device: " Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 11/24] rust: device: make Core and CoreInternal lifetime-parameterized Danilo Krummrich
2026-05-25 20:47 ` Claude Code Review Bot [this message]
2026-05-25 20:20 ` [PATCH v5 12/24] rust: pci: make Driver trait lifetime-parameterized Danilo Krummrich
2026-05-25 20:21 ` [PATCH v5 13/24] rust: platform: " Danilo Krummrich
2026-05-25 20:21 ` [PATCH v5 14/24] rust: auxiliary: " Danilo Krummrich
2026-05-25 20:21 ` [PATCH v5 15/24] rust: usb: " Danilo Krummrich
2026-05-25 20:21 ` [PATCH v5 16/24] rust: i2c: " Danilo Krummrich
2026-05-25 20:21 ` [PATCH v5 17/24] rust: driver: update module documentation for GAT-based Data type Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 18/24] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 19/24] rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 20/24] samples: rust: rust_driver_pci: use HRT lifetime for Bar Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 21/24] gpu: nova-core: separate driver type from driver data Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 22/24] rust: types: add `ForLt` trait for higher-ranked lifetime support Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 23/24] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 24/24] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-25 20:47 ` Claude review: rust: device: Higher-Ranked Lifetime Types for device drivers Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-21 23:34 [PATCH v4 00/27] " Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 10/27] rust: device: make Core and CoreInternal lifetime-parameterized Danilo Krummrich
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch11-20260525202921.124698-12-dakr@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox