public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: auxiliary: generalize Registration over ForLt
Date: Tue, 26 May 2026 06:47:04 +1000	[thread overview]
Message-ID: <review-patch23-20260525202921.124698-24-dakr@kernel.org> (raw)
In-Reply-To: <20260525202921.124698-24-dakr@kernel.org>

Patch Review

`Registration<T>` becomes `Registration<'a, F: ForLt>`. The key split:

```rust
+    pub unsafe fn new_with_lt<E>(
+        parent: &'a device::Device<device::Bound>,
+        ...
+        data: impl PinInit<F::Of<'a>, E>,
+    ) -> Result<Self>
```

vs the safe version:

```rust
+    pub fn new<E>(...) -> Result<Self>
+    where
+        F::Of<'a>: 'static,
+    {
+        unsafe { Self::new_with_lt(parent, name, id, modname, data) }
+    }
```

The `new_with_lt` is unsafe because `mem::forget()` could prevent `Drop` from running, leaving borrowed references dangling. The `new()` is safe when data is `'static` because there are no borrowed references to dangle.

The `registration_data` method uses `ForLt::cast_ref` to shorten the stored `'static` lifetime:

```rust
+        let pinned: Pin<&F::Of<'static>> = unsafe { wrapper.map_unchecked(|w| &w.data) };
+        Ok(unsafe { Pin::new_unchecked(F::cast_ref(pinned.get_ref())) })
```

The `PhantomData<(fn(&'a ()) -> &'a (), F)>` in Registration ensures `'a` is invariant (via the function pointer type), which is correct -- the registration must not outlive the scope it was created in.

The `Registration` no longer wraps in `Devres` -- it's now directly held by the driver. The `Send`/`Sync` impls use `for<'a> F::Of<'a>: Send` instead of `T: Send + Sync`. Dropping `Sync` requirement from the `Send` bound seems intentional -- a `Registration` is moved, not shared.

The transmute from `RegistrationData<F::Of<'a>>` to `RegistrationData<F::Of<'static>>` is sound because lifetimes don't affect layout.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 20:47 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25 20:20 [PATCH v5 00/24] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 01/24] rust: pci: use 'static lifetime for PCI BAR resource names Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:20 ` [PATCH v5 02/24] rust: alloc: remove `'static` bound on `ForeignOwnable` Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:20 ` [PATCH v5 03/24] rust: driver: move 'static bounds to constructor Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:20 ` [PATCH v5 04/24] rust: driver: decouple driver private data from driver type Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:20 ` [PATCH v5 05/24] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:20 ` [PATCH v5 06/24] rust: pci: implement Sync for Device<Bound> Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 07/24] rust: platform: " Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 08/24] rust: auxiliary: " Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 09/24] rust: usb: " Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 10/24] rust: device: " Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 11/24] rust: device: make Core and CoreInternal lifetime-parameterized Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:20 ` [PATCH v5 12/24] rust: pci: make Driver trait lifetime-parameterized Danilo Krummrich
2026-05-25 20:21 ` [PATCH v5 13/24] rust: platform: " Danilo Krummrich
2026-05-25 20:21 ` [PATCH v5 14/24] rust: auxiliary: " Danilo Krummrich
2026-05-25 20:21 ` [PATCH v5 15/24] rust: usb: " Danilo Krummrich
2026-05-25 20:21 ` [PATCH v5 16/24] rust: i2c: " Danilo Krummrich
2026-05-25 20:21 ` [PATCH v5 17/24] rust: driver: update module documentation for GAT-based Data type Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 18/24] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 19/24] rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 20/24] samples: rust: rust_driver_pci: use HRT lifetime for Bar Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 21/24] gpu: nova-core: separate driver type from driver data Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 22/24] rust: types: add `ForLt` trait for higher-ranked lifetime support Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:21 ` [PATCH v5 23/24] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-05-25 20:47   ` Claude Code Review Bot [this message]
2026-05-25 20:21 ` [PATCH v5 24/24] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data Danilo Krummrich
2026-05-25 20:47   ` Claude review: " Claude Code Review Bot
2026-05-25 20:47 ` Claude review: rust: device: Higher-Ranked Lifetime Types for device drivers Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-21 23:34 [PATCH v4 00/27] " Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 22/27] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-05-25  9:29   ` Claude review: " Claude Code Review Bot
2026-05-17  0:00 [PATCH v3 00/27] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-17  0:01 ` [PATCH v3 17/27] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-04-27 22:10 [PATCH 00/24] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-04-27 22:11 ` [PATCH 14/24] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-04-28  3:47   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch23-20260525202921.124698-24-dakr@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox