public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: efifb: fix memory leak in efifb_probe()
Date: Sat, 16 May 2026 11:10:42 +1000	[thread overview]
Message-ID: <review-patch12-20260514-fbdev-v1-12-b3a2474fa720@cse.iitm.ac.in> (raw)
In-Reply-To: <20260514-fbdev-v1-12-b3a2474fa720@cse.iitm.ac.in>

Patch Review

**Status: Correct, but needs verification of the Fixes claim**

```c
 efifb_setup(si, option);
+kfree(option);
```

I verified that `fb_get_options()` calls `kstrdup()` to duplicate the option string, giving ownership to the caller. I also verified that `efifb_setup()` passes `options` by value to `strsep()`, which modifies only the local copy of the pointer — the caller's `option` variable still points to the start of the allocated buffer. So `kfree(option)` is safe.

The key question is whether the referenced commit `73ce73c30ba9` actually changed `fb_get_options()` to use `kstrdup()`. The current code in `fb_cmdline.c` does indeed use `kstrdup()` with a comment saying "The caller owns the string returned in @option and is responsible for releasing the memory." This confirms the fix is correct.

Note this does NOT leak on the `fb_get_options()` failure path since that returns `-ENODEV` before reaching the `kfree`.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  1:10 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  8:24 [PATCH 00/14] fbdev: fix various memory leaks Abdun Nihaal
2026-05-14  8:24 ` [PATCH 01/14] fbdev: hecubafb: fix potential memory leak in hecubafb_probe() Abdun Nihaal
2026-05-15  7:57   ` Thomas Zimmermann
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 02/14] fbdev: broadsheetfb: fix potential memory leak in broadsheetfb_probe() Abdun Nihaal
2026-05-15  7:56   ` Thomas Zimmermann
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 03/14] fbdev: metronomefb: fix potential memory leak in metronomefb_probe() Abdun Nihaal
2026-05-15  7:18   ` Thomas Zimmermann
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 04/14] fbdev: radeon: fix potential memory leak in radeonfb_pci_register() Abdun Nihaal
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 05/14] fbdev: carminefb: fix potential memory leak in alloc_carmine_fb() Abdun Nihaal
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 06/14] fbdev: i740fb: fix potential memory leak in i740fb_probe() Abdun Nihaal
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 07/14] fbdev: nvidia: fix potential memory leak in nvidiafb_probe() Abdun Nihaal
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 08/14] fbdev: s3fb: fix potential memory leak in s3_pci_probe() Abdun Nihaal
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 09/14] fbdev: tdfxfb: fix potential memory leak in tdfxfb_probe() Abdun Nihaal
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 10/14] fbdev: tridentfb: fix potential memory leak in trident_pci_probe() Abdun Nihaal
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 11/14] fbdev: uvesafb: fix potential memory leak in uvesafb_probe() Abdun Nihaal
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 12/14] fbdev: efifb: fix memory leak in efifb_probe() Abdun Nihaal
2026-05-15  7:16   ` Thomas Zimmermann
2026-05-16  1:10   ` Claude Code Review Bot [this message]
2026-05-14  8:24 ` [PATCH 13/14] fbdev: vesafb: fix memory leak in vesafb_probe() Abdun Nihaal
2026-05-15  7:17   ` Thomas Zimmermann
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-14  8:24 ` [PATCH 14/14] fbdev: sm501fb: fix potential memory leak in sm501fb_probe() Abdun Nihaal
2026-05-16  1:10   ` Claude review: " Claude Code Review Bot
2026-05-16  1:10 ` Claude review: fbdev: fix various memory leaks Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch12-20260514-fbdev-v1-12-b3a2474fa720@cse.iitm.ac.in \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox