Claude review: fbdev: sm501fb: fix potential memory leak in sm501fb_probe()

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Status: Needs revision — potential double-free**

```c
 err_alloc:
+#if defined(CONFIG_OF)
+	kfree(info->edid_data);
+#endif
 	kfree(info);
```

I verified in the source tree that `info->edid_data` is allocated via `kmemdup()` under `#if defined(CONFIG_OF)` in `sm501fb_probe()`. However, I found a critical issue:

**`sm501fb_init_fb()` (called from `sm501fb_start()`) already frees `info->edid_data` in certain code paths without setting it to NULL:**

```c
if (info->edid_data) {
    ret = fb_find_mode(...);
    kfree(info->edid_data);
    /* edid_data is NOT set to NULL here! */
}
```

If `sm501fb_start()` succeeds (calling `sm501fb_init_fb()` which frees `edid_data`), but a later step like `register_framebuffer()` fails, the error path goes through `err_started` → `err_probed_panel` → `err_probed_crt` → `err_alloc`, which would call `kfree(info->edid_data)` on an already-freed pointer — a **double-free bug**.

**Recommended fix:** Either:
1. Add `info->edid_data = NULL` after the `kfree()` in `sm501fb_init_fb()` as a separate preparatory patch, or
2. Use `kfree(info->edid_data); info->edid_data = NULL;` pattern here and in `sm501fb_init_fb()`.

Also, the `#if defined(CONFIG_OF)` guard is unnecessary since `edid_data` is unconditionally defined in `struct sm501fb_info` and `kfree(NULL)` is a no-op. Removing the guard would be cleaner.

---
Generated by Claude Code Patch Reviewer