From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/crtc: Add new atomic_create_state callback
Date: Wed, 27 May 2026 14:30:51 +1000 [thread overview]
Message-ID: <review-patch12-20260526-drm-mode-config-init-v6-12-852346394200@kernel.org> (raw)
In-Reply-To: <20260526-drm-mode-config-init-v6-12-852346394200@kernel.org>
Patch Review
Mirrors the plane pattern for CRTCs. The `drm_mode_config_crtc_create_state()` helper also calls `drm_crtc_vblank_reset()` if the device has vblank support, which matches what `__drm_atomic_helper_crtc_reset()` does. Good.
Minor doc nit: double space in "Allocates and initializes" in `drm_atomic_helper_crtc_create_state()`.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-27 4:30 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 16:46 [PATCH v6 00/19] drm/atomic: Rework initial state allocation Maxime Ripard
2026-05-26 16:46 ` [PATCH v6 01/19] drm/atomic: Document atomic commit lifetime Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 02/19] drm/colorop: Fix typos in the doc Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 03/19] drm/atomic: Drop drm_private_obj.state assignment from create_state Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 04/19] drm/atomic: Expand atomic_create_state expectations for drm_private_obj Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 05/19] drm/mode-config: Document drm_private_obj exclusion from drm_mode_config_reset() Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 06/19] drm/colorop: Rename __drm_colorop_state_reset() Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 07/19] drm/colorop: Create drm_atomic_helper_colorop_create_state() Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 08/19] drm/atomic-state-helper: Fix __drm_atomic_helper_plane_reset() doc typo Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 09/19] drm/atomic-state-helper: Rename __drm_atomic_helper_plane_state_reset() Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 10/19] drm/plane: Add new atomic_create_state callback Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 11/19] drm/atomic-state-helper: Rename __drm_atomic_helper_crtc_state_reset() Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 12/19] drm/crtc: Add new atomic_create_state callback Maxime Ripard
2026-05-27 4:30 ` Claude Code Review Bot [this message]
2026-05-26 16:46 ` [PATCH v6 13/19] drm/atomic-state-helper: Rename __drm_atomic_helper_connector_state_reset() Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 14/19] drm/hdmi: Rename __drm_atomic_helper_connector_hdmi_reset() Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 15/19] drm/connector: Add new atomic_create_state callback Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 16/19] drm/mode-config: Create drm_mode_config_create_initial_state() Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 17/19] drm/drv: Switch skeleton to drm_mode_config_create_initial_state() Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 18/19] drm/tidss: Convert to atomic_create_state Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-26 16:46 ` [PATCH v6 19/19] drm/bridge_connector: " Maxime Ripard
2026-05-27 4:30 ` Claude review: " Claude Code Review Bot
2026-05-27 4:30 ` Claude review: drm/atomic: Rework initial state allocation Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-12 13:05 [PATCH v4 00/20] " Maxime Ripard
2026-05-12 13:06 ` [PATCH v4 12/20] drm/crtc: Add new atomic_create_state callback Maxime Ripard
2026-05-16 3:22 ` Claude review: " Claude Code Review Bot
2026-03-20 16:27 [PATCH v2 00/20] drm/atomic: Rework initial state allocation Maxime Ripard
2026-03-20 16:27 ` [PATCH v2 10/20] drm/crtc: Add new atomic_create_state callback Maxime Ripard
2026-03-21 17:32 ` Claude review: " Claude Code Review Bot
2026-03-10 16:06 [PATCH 00/14] drm/atomic: Rework initial state allocation Maxime Ripard
2026-03-10 16:06 ` [PATCH 06/14] drm/crtc: Add new atomic_create_state callback Maxime Ripard
2026-03-11 3:09 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch12-20260526-drm-mode-config-init-v6-12-852346394200@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox