public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel-lvds: Add dual-channel LVDS support
Date: Mon, 25 May 2026 19:56:40 +1000	[thread overview]
Message-ID: <review-patch13-20260521150038.103538-30-ivitro@gmail.com> (raw)
In-Reply-To: <20260521150038.103538-30-ivitro@gmail.com>

Patch Review

This is the most significant binding change. It modifies the `required:` section:

```yaml
-  - port
+
+oneOf:
+  - required:
+      - port
+  - required:
+      - ports
+
+if:
+  required:
+    - ports
+then:
+  $ref: /schemas/display/lvds-dual-ports.yaml#
```

This is architecturally correct — panels should support either single `port` or dual `ports`. The `if/then` conditional reference to `lvds-dual-ports.yaml` is the right mechanism.

**Ordering concern**: This patch (13/15) adds the dual-channel support, but Patch 15 already depends on it. The series ordering has these at 13 and 15, which is correct for application order. However, this binding patch should ideally come before any DTS that uses `ports` (Patch 15 is the only one), so the ordering is fine.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-25  9:56 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 15:00 [PATCH v1 00/15] arm64: dts: ti: k3-am62-verdin: Add display and peripheral overlays Vitor Soares
2026-05-21 15:00 ` [PATCH v1 01/15] dt-bindings: display: panel: Move Logic Technologies LT170410-2WHC to LVDS Vitor Soares
2026-05-21 16:56   ` Conor Dooley
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 02/15] arm64: dts: ti: k3-am62-verdin: Add Toradex DSI to LVDS adapter with 10.1" display Vitor Soares
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 03/15] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 10.1" LVDS Vitor Soares
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 04/15] dt-bindings: vendor-prefixes: Add Riverdi Vitor Soares
2026-05-21 16:54   ` Conor Dooley
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 05/15] dt-bindings: display: panel-lvds: Add Riverdi RVT70HSLNWCA0 and RVT101HVLNWC00 Vitor Soares
2026-05-21 16:57   ` Conor Dooley
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 06/15] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 10.1" DSI Vitor Soares
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 07/15] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 7" DSI Vitor Soares
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 08/15] arm64: dts: ti: k3-am62-verdin: Add NAU8822 Bridge Tied Load Vitor Soares
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 09/15] arm64: dts: ti: k3-am62-verdin: Reserve UART_4 for Cortex-M4F Vitor Soares
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 10/15] arm64: dts: ti: k3-am62-verdin: Add Toradex OV5640 CSI Cameras Vitor Soares
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 11/15] arm64: dts: ti: k3-am62-verdin: Add Toradex Verdin Mezzanine CAN Vitor Soares
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 12/15] arm64: dts: ti: k3-am62-verdin: Add Mezzanine with Toradex Display 10.1" LVDS Vitor Soares
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 13/15] dt-bindings: display: panel-lvds: Add dual-channel LVDS support Vitor Soares
2026-05-21 16:59   ` Conor Dooley
2026-05-22  6:55   ` Krzysztof Kozlowski
2026-05-22  7:34     ` Francesco Dolcini
2026-05-25  9:56   ` Claude Code Review Bot [this message]
2026-05-21 15:00 ` [PATCH v1 14/15] dt-bindings: display: panel-lvds: Add LG LP156WF1 Vitor Soares
2026-05-21 16:54   ` Conor Dooley
2026-05-22  6:53   ` Krzysztof Kozlowski
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-21 15:00 ` [PATCH v1 15/15] arm64: dts: ti: k3-am62-verdin: Add Mezzanine with LG LP156WF1 LVDS panel Vitor Soares
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot
2026-05-25  9:56 ` Claude review: arm64: dts: ti: k3-am62-verdin: Add display and peripheral overlays Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch13-20260521150038.103538-30-ivitro@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox