public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: bridge: dw_hdmi: Rework HDP and RXSENSE interrupt handling
Date: Tue, 05 May 2026 07:58:57 +1000	[thread overview]
Message-ID: <review-patch14-20260504191059.275928-15-jonas@kwiboo.se> (raw)
In-Reply-To: <20260504191059.275928-15-jonas@kwiboo.se>

Patch Review

This is the largest and most impactful patch. It removes all RXSENSE handling, simplifies the IRQ handler to only care about HPD, and removes the `force`, `disabled`, `rxsense`, and `phy_mask` fields from `struct dw_hdmi`.

The simplified `dw_hdmi_phy_setup_hpd()` now sets HPD polarity based on current status:

```c
+	hdmi_modb(hdmi, hdmi_readb(hdmi, HDMI_PHY_STAT0) & HDMI_PHY_HPD ?
+		  0 : HDMI_PHY_HPD, HDMI_PHY_HPD, HDMI_PHY_POL0);
```

This avoids a spurious interrupt at probe/resume when a sink is already connected — the polarity is set to trigger only on the *next* change.

The `dw_hdmi_phy_update_hpd()` is emptied here (removed in patch 16). The `dw_hdmi_setup_rx_sense()` is also emptied (removed in patch 15). This two-step approach (empty then remove) is clean for bisection since external callers (meson, rockchip, sun4i, imx) need their references removed separately.

**Concern about `hdmi->force` removal**: Patch 10 adds `hdmi->force = connector->force;` in `dw_hdmi_connector_force()`, but this patch removes the `force` field from the struct. Looking carefully at the diff for this patch, the `force` assignment in `connector_force` is also removed here:

```c
 	mutex_lock(&hdmi->mutex);
-	hdmi->force = connector->force;
 	hdmi->last_connector_result = connector->status;
```

So this is correct — the field and all its uses are removed atomically in this patch. My earlier concern was unfounded after tracing the full diff. **No Reviewed-by yet.**

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-04 21:58 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 19:10 [PATCH v4 00/17] drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup Jonas Karlman
2026-05-04 19:10 ` [PATCH v4 01/17] drm: bridge: dw_hdmi: Disable scrambler feature when not supported Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 02/17] drm: bridge: dw_hdmi: Only notify connected status on HPD interrupt Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 03/17] drm: bridge: dw_hdmi: Call poweron/poweroff from atomic enable/disable Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 04/17] drm: bridge: dw_hdmi: Use passed mode instead of stored previous_mode Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 05/17] drm: bridge: dw_hdmi: Fold poweron and setup functions Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 06/17] drm: bridge: dw_hdmi: Remove previous_mode and mode_set Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 07/17] drm: bridge: dw_hdmi: Invalidate CEC phys addr from connector detect Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 08/17] drm: bridge: dw_hdmi: Remove cec_notifier_mutex Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 09/17] drm: bridge: dw_hdmi: Extract dw_hdmi_connector_status_update() Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 10/17] drm: bridge: dw_hdmi: Use dw_hdmi_connector_status_update() Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 11/17] drm: bridge: dw_hdmi: Use display_info is_hdmi and has_audio Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 12/17] drm: bridge: dw_hdmi: Use generic CEC notifier helpers Jonas Karlman
2026-05-04 21:21   ` Neil Armstrong
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 13/17] drm: bridge: dw_hdmi: Use delayed_work to debounce hotplug event Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 14/17] drm: bridge: dw_hdmi: Rework HDP and RXSENSE interrupt handling Jonas Karlman
2026-05-04 21:58   ` Claude Code Review Bot [this message]
2026-05-04 19:10 ` [PATCH v4 15/17] drm: bridge: dw_hdmi: Remove the empty dw_hdmi_setup_rx_sense() Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 16/17] drm: bridge: dw_hdmi: Remove the empty dw_hdmi_phy_update_hpd() Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 19:10 ` [PATCH v4 17/17] drm: bridge: dw_hdmi: Merge top and bottom half IRQ handlers Jonas Karlman
2026-05-04 21:58   ` Claude review: " Claude Code Review Bot
2026-05-04 21:58 ` Claude review: drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch14-20260504191059.275928-15-jonas@kwiboo.se \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox