From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: jadard-jd9365da-h3: support Waveshare WXGA DSI panels
Date: Sun, 12 Apr 2026 09:06:56 +1000 [thread overview]
Message-ID: <review-patch15-20260411-waveshare-dsi-touch-v2-15-75cdbeac5156@oss.qualcomm.com> (raw)
In-Reply-To: <20260411-waveshare-dsi-touch-v2-15-75cdbeac5156@oss.qualcomm.com>
Patch Review
Adds Waveshare 8.0" and 10.1" WXGA (800x1280) panels with lane-conditional init sequences.
1. **Bug**: `waveshare_8_0_a_init()` returns `0` instead of `dsi_ctx.accum_err`:
```c
msleep(60);
return 0;
```
Any DSI write errors during init will be silently ignored.
2. **Readability**: `waveshare_10_1_a_init()` has extensive inline `if (jadard->dsi->lanes == 4) ... else ...` conditionals scattered throughout the gamma and GIP configuration, making it very hard to audit. Consider splitting into two separate init sequences or at minimum using lookup tables indexed by lane count.
3. **Style**: Inconsistent braces -- `if` branch without braces, `else` branch with braces in several places, violating kernel coding style.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-11 23:06 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 12:10 [PATCH v2 00/21] drm/panel: support Waveshare DSI TOUCH kits Dmitry Baryshkov
2026-04-11 12:10 ` [PATCH v2 01/21] dt-bindings: display/panel: himax,hx83102: describe Waveshare panel Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 02/21] dt-bindings: display/panel: himax,hx8394: " Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 03/21] dt-bindings: display/panel: jadard,jd9365da-h3: " Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 04/21] dt-bindings: display/panel: ilitek,ili9881c: " Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 05/21] dt-bindings: dipslay/panel: describe panels using Focaltech OTA7290B Dmitry Baryshkov
2026-04-11 14:02 ` Rob Herring (Arm)
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 06/21] drm/of: add helper to count data-lanes on a remote endpoint Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 07/21] drm/panel: himax-hx83102: support Waveshare 12.3" DSI panel Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 08/21] drm/panel: himax-hx8394: set prepare_prev_first Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 09/21] drm/panel: himax-hx8394: simplify hx8394_enable() Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 10/21] drm/panel: himax-hx8394: support Waveshare DSI panels Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 11/21] drm/panel: jadard-jd9365da-h3: use drm_connector_helper_get_modes_fixed Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 12/21] drm/panel: jadard-jd9365da-h3: support variable DSI configuration Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 13/21] drm/panel: jadard-jd9365da-h3: set prepare_prev_first Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 14/21] drm/panel: jadard-jd9365da-h3: support Waveshare round DSI panels Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 15/21] drm/panel: jadard-jd9365da-h3: support Waveshare WXGA " Dmitry Baryshkov
2026-04-11 23:06 ` Claude Code Review Bot [this message]
2026-04-11 12:10 ` [PATCH v2 16/21] drm/panel: jadard-jd9365da-h3: support Waveshare 720p " Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 17/21] drm/panel: ilitek-ili9881c: support Waveshare 7.0" DSI panel Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 18/21] drm/panel: add devm_drm_panel_add() helper Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 19/21] drm/panel: add driver for Waveshare 8.8" DSI TOUCH-A panel Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 20/21] dt-bindings: gpio: describe Waveshare GPIO controller Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 12:10 ` [PATCH v2 21/21] gpio: add GPIO controller found on Waveshare DSI TOUCH panels Dmitry Baryshkov
2026-04-11 23:06 ` Claude review: " Claude Code Review Bot
2026-04-11 23:06 ` Claude review: drm/panel: support Waveshare DSI TOUCH kits Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch15-20260411-waveshare-dsi-touch-v2-15-75cdbeac5156@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox