From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: vop2: Set correct output format for RK3576 YUV422
Date: Mon, 25 May 2026 17:26:12 +1000 [thread overview]
Message-ID: <review-patch18-20260523-color-format-v16-18-24340c5e4732@collabora.com> (raw)
In-Reply-To: <20260523-color-format-v16-18-24340c5e4732@collabora.com>
Patch Review
The per-connector output mode selection for RK3576 is necessary because the hardware uses different register values for DP vs HDMI YUV422. The `drm_err` + `return` for unknown connector types is appropriate.
**Minor:** The `vop2_unlock(vop2)` before `return` in the error path looks correct, but it's worth verifying that the lock is held at this point — which it is, as this code is inside the `vop2_lock/vop2_unlock` scope of `vop2_crtc_atomic_enable`.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 7:26 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 19:43 [PATCH v16 00/28] Add new general DRM property "color format" Nicolas Frattaroli
2026-05-23 19:43 ` [PATCH v16 01/28] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 02/28] drm/display: hdmi-state-helper: Use default case for unsupported formats Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 03/28] drm: Add new general DRM property "color format" Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 04/28] drm/connector: Let connectors have a say in their color format Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 05/28] drm/display: bridge_connector: Use HDMI color format for HDMI conns Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 06/28] drm/bridge: Act on the DRM color format property Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 07/28] drm/atomic-helper: Add HDMI bridge output bus formats helper Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 08/28] drm/display: hdmi-state-helper: Act on color format DRM property Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 09/28] drm/display: hdmi-state-helper: Try subsampling in mode_valid Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 10/28] drm/amdgpu: Implement "color format" DRM property Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 11/28] drm/i915/hdmi: Add YCBCR444 handling for sink formats Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 12/28] drm/i915/dp: " Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 13/28] drm/i915/hdmi: Implement "color format" DRM property Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 14/28] drm/i915/dp: " Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 15/28] drm/rockchip: Add YUV422 output mode constants for VOP2 Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 16/28] drm/rockchip: vop2: Add RK3576 to the RG swap special case Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 17/28] drm/rockchip: vop2: Recognise 10-bit YUV422 as YUV format Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 18/28] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2026-05-25 7:26 ` Claude Code Review Bot [this message]
2026-05-23 19:43 ` [PATCH v16 19/28] drm/bridge: dw-hdmi-qp: Use common HDMI output bus fmts helper Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 20/28] drm/rockchip: dw_hdmi_qp: Implement "color format" DRM property Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 21/28] drm/rockchip: dw_hdmi_qp: Set supported_formats platdata Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 22/28] drm/connector: Register color format property on HDMI connectors Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 23/28] drm/tests: hdmi: Add tests for the color_format property Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:43 ` [PATCH v16 24/28] drm/tests: hdmi: Add tests for HDMI helper's mode_valid Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:44 ` [PATCH v16 25/28] drm/tests: bridge: Add KUnit tests for bridge chain format selection Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:44 ` [PATCH v16 26/28] drm/tests: bridge: Add test for HDMI output bus formats helper Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:44 ` [PATCH v16 27/28] drm/bridge: Document bridge chain format selection Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-23 19:44 ` [PATCH v16 28/28] drm/connector: Update docs of "colorspace" for color format prop Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-05-25 7:26 ` Claude review: Add new general DRM property "color format" Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-22 12:31 [PATCH v15 00/28] " Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 18/28] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-04-09 15:44 [PATCH v12 00/25] Add new general DRM property "color format" Nicolas Frattaroli
2026-04-09 15:45 ` [PATCH v12 15/25] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-03-24 16:01 [PATCH v11 00/22] Add new general DRM property "color format" Nicolas Frattaroli
2026-03-24 16:01 ` [PATCH v11 13/22] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2026-03-24 20:44 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch18-20260523-color-format-v16-18-24340c5e4732@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox