From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: fbdev: Remove offset into framebuffer memory
Date: Thu, 23 Apr 2026 08:46:58 +1000 [thread overview]
Message-ID: <review-patch2-20260421073646.144712-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20260421073646.144712-3-tzimmermann@suse.de>
Patch Review
**Status: Good**
This removes the `xoffset`/`yoffset` adjustment from `screen_buffer` and `smem_start`:
```c
- offset = info->var.xoffset * bytes_per_pixel +
- info->var.yoffset * fb->pitches[0];
...
- info->screen_buffer = bo->vaddr + offset;
+ info->screen_buffer = bo->vaddr;
...
- info->fix.smem_start = (unsigned long)(bo->iova + offset);
+ info->fix.smem_start = (unsigned long)(bo->iova);
```
`screen_buffer` should point to the start of the framebuffer memory region, not offset by display scroll position. The xoffset/yoffset values describe panning within scanout, not the base address of the buffer. This matches how every other fbdev driver in the kernel sets up `screen_buffer`. The Fixes tag pointing all the way back to v3.10 and Cc: stable are appropriate given this has always been wrong.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 22:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 7:29 [PATCH 0/5] drm/tegra: fbdev: Use client buffers Thomas Zimmermann
2026-04-21 7:29 ` [PATCH 1/5] drm/tegra: fbdev: Do not assign to struct drm_fb_helper.info Thomas Zimmermann
2026-04-22 22:46 ` Claude review: " Claude Code Review Bot
2026-04-21 7:29 ` [PATCH 2/5] drm/tegra: fbdev: Remove offset into framebuffer memory Thomas Zimmermann
2026-04-22 22:46 ` Claude Code Review Bot [this message]
2026-04-21 7:29 ` [PATCH 3/5] drm/tegra: fbdev: Calculate buffer geometry with format helpers Thomas Zimmermann
2026-04-22 22:46 ` Claude review: " Claude Code Review Bot
2026-04-21 7:29 ` [PATCH 4/5] drm/tegra: fbdev: Use a DRM client buffer Thomas Zimmermann
2026-04-22 22:46 ` Claude review: " Claude Code Review Bot
2026-04-21 7:29 ` [PATCH 5/5] drm/tegra: Make tegra_fb_alloc() an internal interface Thomas Zimmermann
2026-04-22 22:46 ` Claude review: " Claude Code Review Bot
2026-04-22 22:46 ` Claude review: drm/tegra: fbdev: Use client buffers Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260421073646.144712-3-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox