Claude review: drm/vmwgfx: Move vblank handling into separate helper

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Purpose:** Extracts the vblank event handling and CRC work scheduling from `vmw_vkms_vblank_simulate()` into a new `vmw_vkms_handle_vblank_timeout()` function that matches the `handle_vblank_timeout` callback signature (`bool (*)(struct drm_crtc *)`).

**Assessment: Looks good.**

The split is mechanical and correct. The new `vmw_vkms_handle_vblank_timeout()` contains the vblank handling logic:

```c
bool vmw_vkms_handle_vblank_timeout(struct drm_crtc *crtc)
{
    ...
    locked = vmw_vkms_vblank_trylock(crtc);
    ret = drm_crtc_handle_vblank(crtc);
    WARN_ON(!ret);
    if (!locked)
        return true;
    ...
    return true;
}
```

The function always returns `true` (restart the timer), which preserves the existing behavior: the old code only returned `HRTIMER_NORESTART` when `vmw_vkms_handle_vblank_timeout()` returned false, but it never does. The commit message correctly notes this: "returns true to restart the next vblank timeout even if it could not acquire vmwgfx's vblank lock."

The remaining `vmw_vkms_vblank_simulate()` wrapper is a thin shim that handles the hrtimer-specific forward logic and delegates to the new helper. This wrapper is then cleanly removed in patch 3.

The declaration in `vmwgfx_vkms.h` is correctly added.

No issues.

---

---
Generated by Claude Code Patch Reviewer