From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Use DRM's vblank timer
Date: Tue, 28 Apr 2026 14:31:50 +1000 [thread overview]
Message-ID: <review-overall-20260427150250.699768-1-tzimmermann@suse.de> (raw)
In-Reply-To: <20260427150250.699768-1-tzimmermann@suse.de>
Overall Series Review
Subject: drm/vmwgfx: Use DRM's vblank timer
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 4
Reviewed: 2026-04-28T14:31:50.265693
---
This is a clean, well-structured 3-patch series that replaces vmwgfx's custom hrtimer-based vblank simulation with the shared DRM vblank timer infrastructure. The patches are logically ordered: patch 1 decouples the lock timeout from the timer internals, patch 2 extracts the vblank handling into a callback-compatible helper, and patch 3 performs the actual conversion. The series is a net code reduction (~24 insertions vs ~53 deletions) and the shared DRM implementation provides better race protection in `drm_crtc_vblank_get_vblank_timeout()`.
The series looks correct and ready to merge. I have one minor concern about patch 1 and a minor style nit, but nothing blocking.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-28 4:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 15:00 [PATCH v2 0/3] drm/vmwgfx: Use DRM's vblank timer Thomas Zimmermann
2026-04-27 15:00 ` [PATCH v2 1/3] drm/vmwgfx: Determine lock-waiting timeout from vblank state Thomas Zimmermann
2026-04-28 4:31 ` Claude review: " Claude Code Review Bot
2026-04-27 15:00 ` [PATCH v2 2/3] drm/vmwgfx: Move vblank handling into separate helper Thomas Zimmermann
2026-04-28 4:31 ` Claude review: " Claude Code Review Bot
2026-04-27 15:00 ` [PATCH v2 3/3] drm/vmwgfx: Convert to DRM vblank timers Thomas Zimmermann
2026-04-28 4:31 ` Claude review: " Claude Code Review Bot
2026-04-28 4:31 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260427150250.699768-1-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox