public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: mm: Introduce zone_maybe_fragmented_in_shrinker()
Date: Tue, 05 May 2026 10:13:41 +1000	[thread overview]
Message-ID: <review-patch2-20260430182335.2132382-3-matthew.brost@intel.com> (raw)
In-Reply-To: <20260430182335.2132382-3-matthew.brost@intel.com>

Patch Review

**Overall:** A simple heuristic helper placed in `vmstat.h`. The implementation is straightforward.

```c
return zone_page_state(zone, NR_FREE_PAGES) >
    high_wmark_pages(zone) * 2;
```

**Concerns:**

- **Naming:** The `_in_shrinker` suffix is unusual for a zone-level query. It documents the *intended caller* rather than the *semantic*. Something like `zone_has_free_above_high_wmark` would be more descriptive and wouldn't artificially limit reuse. That said, David Hildenbrand already suggested this name in v3 review, so this may be settled.

- **Heuristic robustness:** The `2x high watermark` threshold is a magic number. On systems where the admin has tuned `min_free_kbytes` high, the watermarks could already be elevated, making this check less meaningful. The commit message acknowledges this is "intentionally imprecise," which is fine for a first pass, but adding a brief comment about the threshold choice directly in the code would help future readers.

- **Inline in header:** Since this is an inline in a widely-included header (`vmstat.h`), it pulls in dependencies on `zone_page_state()` and `high_wmark_pages()`. These are already available in the vmstat.h context so this is fine technically, but it's a public API addition to core mm for what is currently only used by one GPU driver path.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-05  0:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 18:23 [PATCH v3 0/6] mm, drm/ttm, drm/xe: Avoid reclaim/eviction loops under fragmentation Matthew Brost
2026-04-30 18:23 ` [PATCH v3 1/6] mm: Wire up order in shrink_control Matthew Brost
2026-05-05  0:13   ` Claude review: " Claude Code Review Bot
2026-04-30 18:23 ` [PATCH v3 2/6] mm: Introduce zone_maybe_fragmented_in_shrinker() Matthew Brost
2026-05-05  0:13   ` Claude Code Review Bot [this message]
2026-04-30 18:23 ` [PATCH v3 3/6] drm/ttm: Issue direct reclaim at beneficial_order Matthew Brost
2026-05-05  0:13   ` Claude review: " Claude Code Review Bot
2026-04-30 18:23 ` [PATCH v3 4/6] drm/ttm: Introduce ttm_bo_shrink_kswap_maybe_fragmented() Matthew Brost
2026-05-05  0:13   ` Claude review: " Claude Code Review Bot
2026-04-30 18:23 ` [PATCH v3 5/6] drm/xe: Set TTM device beneficial_order to 9 (2M) Matthew Brost
2026-05-05  0:13   ` Claude review: " Claude Code Review Bot
2026-04-30 18:23 ` [PATCH v3 6/6] drm/xe: Avoid shrinker reclaim from kswapd under fragmentation Matthew Brost
2026-05-05  0:13   ` Claude review: " Claude Code Review Bot
2026-05-05  0:13 ` Claude review: mm, drm/ttm, drm/xe: Avoid reclaim/eviction loops " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-30 19:18 [PATCH v4 0/6] " Matthew Brost
2026-04-30 19:18 ` [PATCH v4 2/6] mm: Introduce zone_maybe_fragmented_in_shrinker() Matthew Brost
2026-05-05  0:00   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260430182335.2132382-3-matthew.brost@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox